Skip to content

Fix handling of EAI_SYSTEM for getaddrinfo #10757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 4 commits into from
Jun 8, 2021
Merged

Fix handling of EAI_SYSTEM for getaddrinfo #10757

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
495dd26
Fix handling of EAI_SYSTEM for getaddrinfo
straight-shoota May 28, 2021
5af000e
Disable EAI_SYSTEM check for win32
straight-shoota Jun 1, 2021
89f5b89
Merge branch 'master' into fix/addrinfo-eai_system
straight-shoota Jun 4, 2021
6a2ff11
Refactor back to raising directly at callsite
straight-shoota Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/socket/addrinfo.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,13 @@ class Socket

ret = LibC.getaddrinfo(domain, service.to_s, pointerof(hints), out ptr)
unless ret.zero?
{% if flag?(:posix) %}
# EAI_SYSTEM is not defined on win32
if ret == LibC::EAI_SYSTEM
raise Error.from_errno message, domain: domain
end
{% end %}

error = {% if flag?(:win32) %}
WinError.new(ret.to_u32!)
{% else %}
Expand Down