Port Socket::Addrinfo to win32#10650
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom May 18, 2021
Merged
Conversation
straight-shoota
added
kind:feature
platform:windows
Member
|
I got confused because I thought this PR was the same as #10610 |
straight-shoota
force-pushed
the
feature/win32-addrinfo
branch
from
41393cf to
685bf45
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds bindings for addrinfo in the win32 API and integrates them with
Socket::Addrinfo.The implementation just required a small adoption for error handling and API initialization. Except for that, the existing implementation works as well with WSA as the unix APIs.
Based on #10610 (first two commits) and implements another fraction of #9544.