Add return type restrictions to methods of container types#10582
Merged
straight-shoota merged 6 commits intocrystal-lang:masterfrom Jun 7, 2021
Merged
Add return type restrictions to methods of container types#10582straight-shoota merged 6 commits intocrystal-lang:masterfrom
straight-shoota merged 6 commits intocrystal-lang:masterfrom
Conversation
11 tasks
Member
|
Is there a particular reason why there's sometimes |
Member
Author
|
@straight-shoota "returns actually self" vs "returns another array" |
straight-shoota
approved these changes
Apr 16, 2021
Member
Author
On that topic... In #10243 you added type annotations that totally clash with this idea. So I replace them back. |
Member
|
Ooops, habits.... |
straight-shoota
added a commit
to straight-shoota/crystal
that referenced
this pull request
Jun 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.