Proper handling of max-age and expires for cookies#10564
Merged
straight-shoota merged 14 commits intocrystal-lang:masterfrom Aug 25, 2021
Merged
Proper handling of max-age and expires for cookies#10564straight-shoota merged 14 commits intocrystal-lang:masterfrom
straight-shoota merged 14 commits intocrystal-lang:masterfrom
Conversation
Co-Authored-By: Blacksmoke16 <yomoejoe@gmail.com>
sdogruyol
approved these changes
Aug 20, 2021
Member
sdogruyol
left a comment
sdogruyol
left a comment
There was a problem hiding this comment.
Thank you @straight-shoota 🙏
beta-ziliani
approved these changes
Aug 20, 2021
Member
beta-ziliani
left a comment
beta-ziliani
left a comment
There was a problem hiding this comment.
just with a minor comment
spec/std/http/cookie_spec.cr
Outdated
|
|
||
| it "sets future expiration_time with max-age" do | ||
| cookie = parse_set_cookie("bla=1; max-age=1") | ||
| (cookie.expiration_time.not_nil!).should be > Time.utc |
Member
There was a problem hiding this comment.
Are these parentheses necessary?
Member
Author
There was a problem hiding this comment.
No, I'll remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reissue of #7925. I can't add commits to the original PR, so this is a fresh and more focused start.
This patch adds
max_ageandcreation_timeproperties toHTTP::Cookiewhich allow a more versatile handling of expiration times.Resolves #5033
Closes #7925