Add stricter checks for arguments to macro methods on AST nodes#10498
Merged
straight-shoota merged 10 commits intocrystal-lang:masterfrom Aug 24, 2021
Merged
Add stricter checks for arguments to macro methods on AST nodes#10498straight-shoota merged 10 commits intocrystal-lang:masterfrom
straight-shoota merged 10 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
approved these changes
Mar 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Crystal's macro interpreter is very lax when it comes to macro methods on AST nodes:
{% [1, 2].includes?(1, a: "x") { |b, c| } %} # named args and block silently allowed {% [1].uniq(2, 3, 4) %} # some methods don't check their args at allOther times, the error messages related to parameter-argument matching are inconsistent with other places in the compiler:
This PR fixes all of these with a new
interpret_check_argsmacro, replacing the oldinterpret_argless_methodand friends; this shouldn't break any code that already obeys the API docs onsrc/compiler/crystal/macros.cr.It's best to review each commit in isolation instead of all at once. Error messages for AST node type mismatches (
argument must be a T, not U) will be covered later.