Enable REGEXP by connecting Crystal's stdlib Regex #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
reviewed
Nov 10, 2020
bcardiff
reviewed
Nov 10, 2020
src/sqlite3/connection.cr
Outdated
| @@ -87,3 +89,11 @@ class SQLite3::Connection < DB::Connection | |||
| raise Exception.new(self) unless code == 0 | |||
| end | |||
| end | |||
|
|
|||
| REGEXP_FN = ->(context : LibSQLite3::SQLite3Context, argc : Int32, argv : LibSQLite3::SQLite3Value*) do | |||
There was a problem hiding this comment.
Great, but let's leave this constant within SQLite3 namespace.
module SQLite3
# :nodoc:
REGEXP_FN = ->(context : ...
endIt's better if placed either at the beginning of this file or at src/sqlite3.cr. Either will work.
Other than that, LGTM!
There was a problem hiding this comment.
Thanks! I put it in src/sqlite3.cr.
bcardiff
approved these changes
Nov 10, 2020
|
Thanks @yujiri8 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #61.
Phew! This took me a long time to figure out. I've never worked with Crystal's FFI before. Ideally this should expose the
create_functioninterface fully, but I hope to get feedback on the code before I try to take it farther. I can add tests tomorrow.