preparedstatements?

[rdp]

Do they exist? If not, they are convenient at times, thanks!

[straight-shoota]

crystal-db implicitly uses prepared statements by default, unless configured otherwise.

[rdp]

So for query parameters it is using a preparedstatement under the covers?

…

On Tue, Apr 5, 2022 at 1:54 PM Johannes Müller ***@***.***> wrote: crystal-db implicitly uses prepared statements by default, unless configured otherwise. — Reply to this email directly, view it on GitHub <#164 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAADBUG3YPT3LEAS2J3I3CLVDSK5XANCNFSM5STZPZLQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[straight-shoota]

By default, yes (and if the driver supports it, but AFAIK all existing drivers do). You can disable prepared statements in the connection config via prepared_statements=false. Or you can explicitly run unprepared statements.
More details are available in #25, but we're really lacking documentation on this.

[rdp]

Yeah that wasn't super clear...I may do a PR for it.

Having "prepared statement" objects might be nice for named parameters, setting parameters separately, etc. but query parameters will work for now for me, thanks! Prepared statements might help with speed on occasion too I'm not sure.

In more general feedback, it's also a bit odd that one driver has a different syntax for query parameters (i.e. prepared statements) than others, as well, though I guess that might be OK for now since few use different DB's. Cheers!

[straight-shoota]

it's also a bit odd that one driver has a different syntax for query parameters (i.e. prepared statements) than others, as well, though I guess that might be OK for now since few use different DB's.

Well, that syntax directly depends on the database. The drivers don't interpreter query parameters, they just pass the raw query to the server, thus it must use the specific parameter syntax of the respective database.

[straight-shoota]

Having "prepared statement" objects might be nice for named parameters, setting parameters separately

You can use Database#build or Connection#build to create a statement instance.

Prepared statements might help with speed on occasion too I'm not sure.

Definitely! Prepared statements are cached, so the server doesn't need to re-interpret the same query again.

[rdp]

For followers, it's like this in Postgres:

b = db.build("select $1::int")
b.query("2") # no query_one method? Error: undefined method 'query_one' for PG::Statement (compile-time type is DB::Statement+)

Thanks.

[rdp]

Might be nice if prepared statements could be created in "block form" for auto-closing but maybe since they're manual that's not needed?