Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid always applying primary.control scope to type #41

Closed
faultyserver opened this issue Apr 5, 2018 · 1 comment
Closed

Avoid always applying primary.control scope to type #41

faultyserver opened this issue Apr 5, 2018 · 1 comment
Labels

Comments

@faultyserver
Copy link
Contributor

screen shot 2018-04-05 at 7 32 21 pm

I often end up using the word type in my code for various things. But, it almost always ends up getting highlighted incorrectly for the context in which it's being used.

afaik, the only place where type is a valid keyword is inside of a lib definition, or in macros (and even then, it's @type), so I think the highlighting for the word should be restricted to that context.

@jhass
Copy link

jhass commented Apr 6, 2018

type is a stronger version of alias, so it can be used almost everywhere. The highlighter should rather check whether it's directly followed by a constant or not.

@faustinoaq faustinoaq added the bug label Apr 6, 2018
@faustinoaq faustinoaq added this to To do in Crystal Tools via automation Apr 6, 2018
aljelly added a commit to aljelly/sublime-crystal that referenced this issue Jan 12, 2020
Crystal Tools automation moved this from To do to Done May 28, 2020
max-bertinetti pushed a commit that referenced this issue May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Crystal Tools
  
Done
Development

No branches or pull requests

4 participants