This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Handle exit and shutdown request #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add shutdown class_property to check if shutdown has been triggered * Add dispatch_request(params : Nil, msg) to handle exit and shutdown * Rename CamelCased methods on context.cr to follow crystal code style
|
#75 already cover an spec for this 👍 |
damieng
reviewed
Apr 9, 2018
src/scry/context.cr
Outdated
| if msg.method == "shutdown" | ||
| Scry.shutdown = true | ||
| ResponseMessage.new(msg.id, nil) | ||
| elsif msg.method == "exit" |
There was a problem hiding this comment.
I think the 'exit' handling needs to be in dispatch_notification as it is a notification message not a request message (unlike shutdown which is in the correct place)
|
Looks good to me. |
keplersj
approved these changes
Apr 9, 2018
bmulvihill
approved these changes
Apr 9, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69 and replaces #70
/cc @damieng