Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

On ci check that code is formatted #57

Merged
merged 2 commits into from
Mar 9, 2018
Merged

On ci check that code is formatted #57

merged 2 commits into from
Mar 9, 2018

Conversation

laginha87
Copy link
Contributor

No description provided.

Copy link
Contributor

@keplersj keplersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'd even suggest we consider formatting in a git-hook, similar to lint-staged.

@faustinoaq
Copy link
Member

I approve this but What about using ameba by @veelenga?

I added it to amber and works pretty well 😅

amberframework/amber#465

Maybe we can add it in other PR, WDYT?

@keplersj
Copy link
Contributor

keplersj commented Mar 9, 2018

😮 Ameba is a thing? Sounds like a good replacement for atom-linter-crystal now that atom-ide-crystal covers diagnostics sufficiently.

@laginha87
Copy link
Contributor Author

Ameba seems like a good idea as well and we can add it later.
I created this PR because I noticed I had committed unformatted code on the last PR and it was easily avoidable on travis.

@faustinoaq faustinoaq mentioned this pull request Mar 9, 2018
@faustinoaq
Copy link
Member

Ameba seems like a good idea as well and we can add it later.

Yeah, I opened #58 to track this 👍

@faustinoaq faustinoaq merged commit 2e988b7 into master Mar 9, 2018
@faustinoaq faustinoaq deleted the add-format-check branch March 9, 2018 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants