Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Support Crystal 0.34.0#170

Merged
bew merged 7 commits into
crystal-lang-tools:masterfrom
marcosdsanchez:support-crystal-0.34
Apr 27, 2020
Merged

Support Crystal 0.34.0#170
bew merged 7 commits into
crystal-lang-tools:masterfrom
marcosdsanchez:support-crystal-0.34

Conversation

@marcosdsanchez
Copy link
Copy Markdown
Contributor

@marcosdsanchez marcosdsanchez commented Apr 20, 2020 •
edited
Loading

Tasks Done

  • Update the crystal version used by the docker image.
  • Errno was replaced by RuntimeError.
  • AtExitHandlers was moved to crystal namespace.
  • Logger class is deprecated.

Todo

  • Fix can't prove case is exhaustive warnings

.

@bew
Copy link
Copy Markdown
Contributor

bew commented Apr 20, 2020 •
edited
Loading

You'll also have to update the crystal version used by the docker image used for the build!

Currently its using 0.31.0

@marcosdsanchez marcosdsanchez changed the title Support Crystal 0.3.5 Support Crystal 0.3.4 Apr 20, 2020
@marcosdsanchez marcosdsanchez changed the title Support Crystal 0.3.4 Support Crystal 0.3.4.0 Apr 20, 2020
@marcosdsanchez marcosdsanchez changed the title Support Crystal 0.3.4.0 Support Crystal 0.34.0 Apr 20, 2020
@marcosdsanchez
Copy link
Copy Markdown
Contributor Author

marcosdsanchez commented Apr 20, 2020

You'll also have to update the crystal version used by the docker image used for the build!
Currently its using 0.31.0

Done. Let me know it's fine. I'm not using Docker myself.

@marcosdsanchez
Copy link
Copy Markdown
Contributor Author

marcosdsanchez commented Apr 21, 2020

Specs pass since 836950d . The next commits are to fix warnings. I'm using this PR to learn Crystal so feedback is very welcome 😄

@bew
Copy link
Copy Markdown
Contributor

bew commented Apr 21, 2020 •
edited
Loading

🎉 on making the tests go green! Welcome to Crystal 😃

About the new Log, see #168, I've written a few comments there as well, you can try to apply them here if you want!

Otherwise we can merge the most important changes, and I'll try to apply my comments in another PR this week or weekend if I don't forget

bew
bew reviewed Apr 21, 2020
View reviewed changes
Comment thread src/scry/log.cr
@marcosdsanchez
Copy link
Copy Markdown
Contributor Author

marcosdsanchez commented Apr 25, 2020

Hey @bew I'm not sure I'll be able to work on this, this weekend. Feel free to cherry-pick the commits that you think are good and do the Log changes. I don't want to leave others waiting for me. I'm sorry about that. I'll try to work on this during the weekend if I find time.

@marcosdsanchez marcosdsanchez requested a review from bew April 26, 2020 04:43
@marcosdsanchez
Copy link
Copy Markdown
Contributor Author

marcosdsanchez commented Apr 26, 2020

Hey @bew I'm not sure I'll be able to work on this, this weekend. Feel free to cherry-pick the commits that you think are good and do the Log changes. I don't want to leave others waiting for me. I'm sorry about that. I'll try to work on this during the weekend if I find time.

I actually had some time 😸 . I made some changes. Let me know if that's what you planned.

@bew
Copy link
Copy Markdown
Contributor

bew commented Apr 26, 2020 •
edited
Loading

It's exactly what I had in mind! Thank you for your contribution 😃

@bew bew merged commit e648e65 into crystal-lang-tools:master Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bew bew bew approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcosdsanchez @bew