fix: don't send keep-alive if we want reset (nodejs#1846)

crysmags · Feb 27, 2024 · 4624b04 · 4624b04
1 parent 9b82548
commit 4624b04
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -1395,7 +1395,7 @@ function write (client, request) {
 
   if (upgrade) {
     header += `connection: upgrade\r\nupgrade: ${upgrade}\r\n`
-  } else if (client[kPipelining]) {
+  } else if (client[kPipelining] && !socket[kReset]) {
     header += 'connection: keep-alive\r\n'
   } else {
     header += 'connection: close\r\n'

diff --git a/test/proxy-agent.js b/test/proxy-agent.js
@@ -323,7 +323,7 @@ test('ProxyAgent correctly sends headers when using fetch - #1355, #1623', { ski
 
   const expectedProxyHeaders = {
     host: `localhost:${proxy.address().port}`,
-    connection: 'keep-alive'
+    connection: 'close'
   }
 
   proxy.on('connect', (req, res) => {