Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm modals cancel issue #1576

Closed
yflory opened this issue Jul 24, 2024 · 0 comments
Closed

Confirm modals cancel issue #1576

yflory opened this issue Jul 24, 2024 · 0 comments
Assignees
@yflory
Labels
Fixed in staging This is live on staging branch
Milestone
Summer release bu...

Comments

@yflory
Copy link
Contributor

yflory commented Jul 24, 2024

Description

If you focus the "Cancel" button and press "Enter" in a confirm modal, it will trigger the "OK" button action.

Steps to reproduce

  1. Create a pad
  2. Store it in your drive
  3. Use File / "Move to trash" to get a confirm modal
  4. Focus "Cancel" using keyboard
  5. Press Enter
  6. Your pad has been moved to the trash

Relevant logs

No response

Expected behavior

The Cancel button shouldn't trigger the OK action 🥲

Which operating system are you using?

No response

What browsers are you seeing the problem on?

No response

Extensions

Version

2024.6.0
@yflory yflory added this to the Summer release bugfix 2024.6.1 milestone Jul 24, 2024
@yflory yflory self-assigned this Jul 24, 2024
yflory added a commit that referenced this issue Jul 24, 2024
@yflory
Fix cancel button in UI.confirm #1576
eec885f
@yflory yflory added the Fixed in staging This is live on staging branch label Jul 24, 2024
@yflory yflory closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yflory yflory

Labels
Fixed in staging This is live on staging branch
Projects
None yet
Milestone
Summer release bugfix 2024.6.1
Development

No branches or pull requests
1 participant
@yflory