Correct documentation of AAD for file content encryption#54
Correct documentation of AAD for file content encryption#54overheadhunter merged 1 commit intocryptomator:mainfrom
Conversation
The documentation stated the chunk number is encoded as 32-bit integer. However, cryptolib FileContentCryptorImpl actually uses a 64-bit integer. This corrects the documentation to reflect cryptolib's actual behaviour.
WalkthroughThe latest update enhances the encryption process by increasing the chunk number size from a 32-bit to a 64-bit big endian integer. This change aims to prevent the undetected reordering of chunks, thereby improving data integrity and security. Changes
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
source/security/vault.rst (1)
52-52: Correctly updated the chunk number size from 32-bit to 64-bit big endian integer.Consider adding a brief explanation or a reference link about why using a 64-bit integer enhances security, such as preventing undetected reordering of chunks.
|
You are right (and coderabbit is not). Thanks for correcting this! |
3 participants
The documentation at https://docs.cryptomator.org/en/latest/security/architecture/ currently states:
However, as per FileContentCryptorImpl (line 155), the chunk number is actually packed into
Long.SIZEbits, which is 64 bits, not 32.This pull request corrects the documentation.