Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node modules version for electron #148

Merged
merged 1 commit into from
May 31, 2019
Merged

Conversation

fanatid
Copy link
Member

@fanatid fanatid commented May 31, 2019

Was introduced in #143, issue #147
When added node@12 support, nan did not had NODE_12_0_MODULE_VERSION, equal to 72. NODE_11_0_MODULE_VERSION equal to 67. Electron can have versions between 67 and 72, so condition:

NODE_MODULE_VERSION > NODE_11_0_MODULE_VERSION

broken building for Electron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant