forked from evmos/ethermint
-
Notifications
You must be signed in to change notification settings - Fork 53
fix: staking optimization v1.6.x patch #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
randy-cro
wants to merge
2
commits into
crypto-org-chain:release/v0.22.x
Choose a base branch
from
randy-cro:fix/staking-optimization-1.5.x-patch
base: release/v0.22.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: staking optimization v1.6.x patch #779
randy-cro
wants to merge
2
commits into
crypto-org-chain:release/v0.22.x
from
randy-cro:fix/staking-optimization-1.5.x-patch
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.22.x #779 +/- ##
===================================================
+ Coverage 46.75% 46.88% +0.12%
===================================================
Files 187 189 +2
Lines 15221 15275 +54
===================================================
+ Hits 7117 7162 +45
- Misses 7316 7325 +9
Partials 788 788
🚀 New features to boost your workflow:
|
2cbdd91 to
c404b83
Compare
c404b83 to
a64e281
Compare
13 tasks
632f519 to
8b771f4
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
d2d7d02 to
b338cac
Compare
JayT106
reviewed
Nov 18, 2025
JayT106
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5be42f7 to
a2d9338
Compare
a2d9338 to
7e9c1c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch introduces a fixed gas consumption decorator in the antehandler to standardize gas usage for whitelisted messages.
Currently, only staking-related messages are included in the whitelist.
Purpose
This ensures consistent gas consumption across all nodes, regardless of variations in staking cache size.
By normalizing gas usage, it prevents potential AppHash mismatches caused by node-specific performance differences.
Implementation Details
For example, the mean gas used for
MsgUndelegatecan be referenced here:Mainnet reference
This change works in tandem with the staking cache introduced in the Cosmos SDK:
crypto-org-chain/cosmos-sdk#1733
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)