Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: validation broke after transaction conversion with raw field #536

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Oct 2, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe requested a review from yihuang October 2, 2024 04:20
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.56%. Comparing base (c4cef0f) to head (7e402e3).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/types/eth.go 30.00% 5 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #536   +/-   ##
========================================
  Coverage    46.56%   46.56%           
========================================
  Files          181      181           
  Lines        14506    14512    +6     
========================================
+ Hits          6754     6758    +4     
- Misses        7037     7040    +3     
+ Partials       715      714    -1     
Files with missing lines Coverage Δ
x/evm/types/msg.go 60.21% <ø> (ø)
x/evm/types/eth.go 48.07% <30.00%> (+2.42%) ⬆️

x/evm/types/eth.go Outdated Show resolved Hide resolved
x/evm/types/msg.go Outdated Show resolved Hide resolved
x/evm/types/msg.go Outdated Show resolved Hide resolved
x/evm/types/msg.go Outdated Show resolved Hide resolved
x/evm/types/eth.go Outdated Show resolved Hide resolved
x/evm/types/eth.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chain-id validation seems unnecessary, otherwise LGTM.

@mmsqe mmsqe enabled auto-merge (squash) October 4, 2024 06:58
@mmsqe mmsqe merged commit 617eac9 into crypto-org-chain:develop Oct 4, 2024
36 of 39 checks passed
@yihuang yihuang deleted the validate branch October 4, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants