Problem: opBlockhash broke after sdk50 #534
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #534 +/- ##
===========================================
- Coverage 46.56% 46.48% -0.09%
===========================================
Files 181 181
Lines 14512 14529 +17
===========================================
- Hits 6758 6754 -4
- Misses 7040 7059 +19
- Partials 714 716 +2
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return err | ||
| } | ||
|
|
||
| k.SetHeaderHash(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| for i := ctx.BlockHeight() - headerHashNum; i >= 0; i-- { | ||
| h, err := ethermint.SafeUint64(i) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| for i := ctx.BlockHeight() - headerHashNum; i >= 0; i-- { | ||
| h, err := ethermint.SafeUint64(i) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| store := prefix.NewStore(ctx.KVStore(k.storeKey), types.KeyPrefixHeaderHash) | ||
| height, err := ethermint.SafeUint64(ctx.BlockHeight()) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| k.SetHeaderHash(ctx) | ||
| headerHashNum, err := ethermint.SafeInt64(cfg.Params.GetHeaderHashNum()) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
| k.SetHeaderHash(ctx) | ||
| headerHashNum, err := ethermint.SafeInt64(cfg.Params.GetHeaderHashNum()) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
Signed-off-by: yihuang <[email protected]>
Signed-off-by: yihuang <[email protected]>
Signed-off-by: yihuang <[email protected]>
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)