Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: ethermint 'remove tx logs' version is not used #70

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 14, 2021

evmos/ethermint#556

Removed tx logs and block bloom from chain state in ethermint side, check that Cronos CI checks all passes.

Update dependency after upstream PR merged.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner September 14, 2021 02:56
@yihuang yihuang requested review from calvinaco and thomas-nguy and removed request for a team September 14, 2021 02:56
@yihuang yihuang marked this pull request as draft September 14, 2021 02:56
@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #70 (28b49f7) into main (3ea70c5) will increase coverage by 4.64%.
The diff coverage is 41.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   21.51%   26.15%   +4.64%     
==========================================
  Files          27       32       +5     
  Lines        1729     2183     +454     
==========================================
+ Hits          372      571     +199     
- Misses       1324     1575     +251     
- Partials       33       37       +4     
Impacted Files Coverage Δ
app/app.go 3.89% <0.00%> (-0.07%) ⬇️
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/hooks.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 6.45% <0.00%> (ø)
x/cronos/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/cronos/types/tracer.go 0.00% <0.00%> (ø)
x/cronos/keeper/evm.go 57.62% <66.66%> (+5.90%) ⬆️
x/cronos/keeper/evmhooks.go 80.00% <80.00%> (ø)
x/cronos/keeper/evm_log_handlers.go 86.51% <86.51%> (ø)
x/cronos/keeper/ibc.go 83.06% <100.00%> (+4.88%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06a5f72...28b49f7. Read the comment docs.

go.mod Outdated Show resolved Hide resolved
@yihuang yihuang marked this pull request as ready for review September 15, 2021 09:56
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

github.com/tendermint/tm-db v0.6.4
github.com/tharsis/ethermint v0.4.2-0.20210905110306-26c5eabb1893
google.golang.org/genproto v0.0.0-20210903162649-d08c68adba83
github.com/tharsis/ethermint v0.4.2-0.20210915094503-116de5461766
Copy link
Collaborator

@thomas-nguy thomas-nguy Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tag should be v0.5.1?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's figured out by go mod tidy automatically, not sure why it didn't pick the v0.5 tag

@yihuang yihuang merged commit 2fc81a6 into crypto-org-chain:main Sep 16, 2021
@yihuang yihuang deleted the remove-tx-logs branch September 16, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants