-
Notifications
You must be signed in to change notification settings - Fork 276
chore(attestation): remove collector #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: randy/da-integration-test
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thomas-nguy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup looks good but can you tell me why do we need a rpcClient?
c582bb5 to
d82a3d5
Compare
It's a cometbft rpc client to let cosmos module to access the history block data since we don't store the block or the block metadata in app side. BTW, found we can use local client to remove HTTP overhead and network latency. |
Remove collector based on the discussion in here #1948 (comment)
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)