Skip to content

Conversation

@JayT106
Copy link
Contributor

@JayT106 JayT106 commented Jan 8, 2026

Remove collector based on the discussion in here #1948 (comment)

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@JayT106 JayT106 requested a review from randy-cro January 8, 2026 00:38
@JayT106 JayT106 requested a review from a team as a code owner January 8, 2026 00:38
@JayT106 JayT106 requested review from XinyuCRO and removed request for a team January 8, 2026 00:38
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup looks good but can you tell me why do we need a rpcClient?

@JayT106 JayT106 force-pushed the jt/remove-collector branch from c582bb5 to d82a3d5 Compare January 8, 2026 15:07
Base automatically changed from jay/da-cleanup to randy/da-integration-test January 8, 2026 15:08
@JayT106
Copy link
Contributor Author

JayT106 commented Jan 8, 2026

cleanup looks good but can you tell me why do we need a rpcClient?

It's a cometbft rpc client to let cosmos module to access the history block data since we don't store the block or the block metadata in app side.

BTW, found we can use local client to remove HTTP overhead and network latency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants