-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: recent bug fixes are not included #1746
base: release/v1.3.x
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v1.3.x #1746 +/- ##
==================================================
+ Coverage 36.29% 36.32% +0.03%
==================================================
Files 146 146
Lines 12623 12629 +6
==================================================
+ Hits 4581 4588 +7
+ Misses 7587 7586 -1
Partials 455 455
|
time.sleep(3) | ||
print(cli.changeset_fixdata(f"{c.base_dir}/node0/data/versiondb", dry_run=True)) | ||
cli.changeset_fixdata(f"{c.base_dir}/node0/data/versiondb") | ||
print(cli.changeset_fixdata(f"{c.base_dir}/node0/data/versiondb", dry_run=True)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yihuang have fix data: feemarket after fixdata
…#1745) * Problem: miss diff info when assert from test utils * align rootdir * fix upload
crypto-org-chain#1747) * Problem: need batch initialization run fixdata with dry-run * mod tidy * skip flush
…rypto-org-chain#1748) * Problem: need run fixdata multiple times when no timestamp checking query with GetCFWithTS to compare both timestamp and key * cleanup * doc
…ksdb (crypto-org-chain#1751) * Problem: no deallocate read options * doc * sync deps
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)