Merge pull request go-mail#26 from zcalusic/v2

Fix MIME-Version header field case
cryptix · Jun 9, 2018 · c55e3fb · c55e3fb
2 parents 5bc5c8b + 2449c75
commit c55e3fb
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,11 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - #12: Adds `SendError` to provide additional info about the cause and index of
   a failed attempt to transmit a batch of messages.
 
+### Fixed
+
+- #26: Fixes RFC 1341 compliance by properly capitalizing the
+  `MIME-Version` header.
+
 ## [2.2.0] - 2018-03-01
 
 ### Added

diff --git a/message_test.go b/message_test.go
@@ -657,7 +657,7 @@ func stubSendMail(t *testing.T, bCount int, want *message) SendFunc {
 			t.Error(err)
 		}
 		got := buf.String()
-		wantMsg := string("Mime-Version: 1.0\r\n" +
+		wantMsg := string("MIME-Version: 1.0\r\n" +
 			"Date: Wed, 25 Jun 2014 17:46:00 +0000\r\n" +
 			want.content)
 		if bCount > 0 {

diff --git a/send_test.go b/send_test.go
@@ -15,7 +15,7 @@ const (
 	testBody = "Test message"
 	testMsg  = "To: " + testTo1 + ", " + testTo2 + "\r\n" +
 		"From: " + testFrom + "\r\n" +
-		"Mime-Version: 1.0\r\n" +
+		"MIME-Version: 1.0\r\n" +
 		"Date: Wed, 25 Jun 2014 17:46:00 +0000\r\n" +
 		"Content-Type: text/plain; charset=UTF-8\r\n" +
 		"Content-Transfer-Encoding: quoted-printable\r\n" +

diff --git a/writeto.go b/writeto.go
@@ -19,8 +19,8 @@ func (m *Message) WriteTo(w io.Writer) (int64, error) {
 }
 
 func (w *messageWriter) writeMessage(m *Message) {
-	if _, ok := m.header["Mime-Version"]; !ok {
-		w.writeString("Mime-Version: 1.0\r\n")
+	if _, ok := m.header["MIME-Version"]; !ok {
+		w.writeString("MIME-Version: 1.0\r\n")
 	}
 	if _, ok := m.header["Date"]; !ok {
 		w.writeHeader("Date", m.FormatDate(now()))