Skip to content

feat(diagnostics): promote Diagnostics to production feature level #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewazores merged 1 commit into from
Oct 3, 2025
Merged

feat(diagnostics): promote Diagnostics to production feature level #1838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 35 additions & 40 deletions src/app/Dashboard/Diagnostics/DiagnosticsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
DashboardCardDescriptor,
} from '@app/Dashboard/types';
import { CryostatLink } from '@app/Shared/Components/CryostatLink';
import { FeatureFlag } from '@app/Shared/Components/FeatureFlag';
import { NotificationCategory } from '@app/Shared/Services/api.types';
import { NotificationsContext } from '@app/Shared/Services/Notifications.service';
import { FeatureLevel } from '@app/Shared/Services/service.types';
Expand Down Expand Up @@ -206,51 +205,47 @@ export const DiagnosticsCard: DashboardCardFC<DiagnosticsCardProps> = (props) =>
</ActionList>
</StackItem>
<StackItem>
<FeatureFlag level={FeatureLevel.BETA}>
<ActionList>
<ActionList>
<Button
variant="primary"
onClick={handleThreadDump}
spinnerAriaValueText="Invoke Thread Dump"
spinnerAriaLabel="invoke-thread-dump"
isLoading={running}
>
{t('DiagnosticsCard.DIAGNOSTICS_THREAD_DUMP_BUTTON')}
</Button>
<Tooltip content={t('DiagnosticsCard.DIAGNOSTICS_THREAD_DUMP_TABLE_TOOLTIP')}>
<Button
variant="primary"
onClick={handleThreadDump}
spinnerAriaValueText="Invoke Thread Dump"
spinnerAriaLabel="invoke-thread-dump"
isLoading={running}
>
{t('DiagnosticsCard.DIAGNOSTICS_THREAD_DUMP_BUTTON')}
</Button>
<Tooltip content={t('DiagnosticsCard.DIAGNOSTICS_THREAD_DUMP_TABLE_TOOLTIP')}>
<Button
variant="primary"
isAriaDisabled={!threadDumpReady}
component={(props) => <CryostatLink {...props} to="/thread-dumps" />}
icon={<ListIcon />}
/>
</Tooltip>
</ActionList>
</FeatureFlag>
isAriaDisabled={!threadDumpReady}
component={(props) => <CryostatLink {...props} to="/thread-dumps" />}
icon={<ListIcon />}
/>
</Tooltip>
</ActionList>
</StackItem>
<StackItem>
<FeatureFlag level={FeatureLevel.BETA}>
<ActionList>
<ActionList>
<Button
variant="primary"
onClick={handleHeapDump}
isAriaDisabled={!controlEnabled}
spinnerAriaValueText="Invoke Heap Dump"
spinnerAriaLabel="invoke-heap-dump"
isLoading={running}
>
{t('DiagnosticsCard.DIAGNOSTICS_HEAP_DUMP_BUTTON')}
</Button>
<Tooltip content={t('DiagnosticsCard.DIAGNOSTICS_HEAP_REDIRECT_BUTTON')}>
<Button
variant="primary"
onClick={handleHeapDump}
isAriaDisabled={!controlEnabled}
spinnerAriaValueText="Invoke Heap Dump"
spinnerAriaLabel="invoke-heap-dump"
isLoading={running}
>
{t('DiagnosticsCard.DIAGNOSTICS_HEAP_DUMP_BUTTON')}
</Button>
<Tooltip content={t('DiagnosticsCard.DIAGNOSTICS_HEAP_REDIRECT_BUTTON')}>
<Button
variant="primary"
isAriaDisabled={!(heapDumpReady && controlEnabled)}
component={(props) => <CryostatLink {...props} to="/heapdumps" />}
icon={<ListIcon />}
/>
</Tooltip>
</ActionList>
</FeatureFlag>
isAriaDisabled={!(heapDumpReady && controlEnabled)}
component={(props) => <CryostatLink {...props} to="/heapdumps" />}
icon={<ListIcon />}
/>
</Tooltip>
</ActionList>
</StackItem>
</Stack>
</EmptyStateFooter>
Expand Down
3 changes: 0 additions & 3 deletions src/app/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ const diagnosticsRoutes: IAppRoute[] = [
title: 'Capture',
description: 'Perform garbage collection and create thread dumps on single target JVMs.',
navGroup: DIAGNOSTICS,
featureLevel: FeatureLevel.BETA,
},
{
component: AnalyzeThreadDumps,
Expand All @@ -188,7 +187,6 @@ const diagnosticsRoutes: IAppRoute[] = [
description: 'View thread dumps on single target JVMs.',
navGroup: DIAGNOSTICS,
navSubgroup: ANALYZE,
featureLevel: FeatureLevel.BETA,
},
{
component: AnalyzeHeapDumps,
Expand All @@ -198,7 +196,6 @@ const diagnosticsRoutes: IAppRoute[] = [
description: 'Create and view heap dumps on single target JVMs.',
navGroup: DIAGNOSTICS,
navSubgroup: ANALYZE,
featureLevel: FeatureLevel.BETA,
},
];

Expand Down
Loading