Skip to content

feat(diagnostics): Add all Targets view for diagnostics#1809

Merged
andrewazores merged 12 commits intocryostatio:mainfrom
Josh-Matsuoka:all-targets-2
Oct 1, 2025
Merged

feat(diagnostics): Add all Targets view for diagnostics#1809
andrewazores merged 12 commits intocryostatio:mainfrom
Josh-Matsuoka:all-targets-2

Conversation

@Josh-Matsuoka
Copy link
Copy Markdown
Contributor

@Josh-Matsuoka Josh-Matsuoka commented Sep 12, 2025

Fixes: #1796

Depends on #1730 cryostatio/cryostat#1051

Adds an all-targets view to Analyze/Thread-Dumps which allows the user to see a view of all of the thread dumps available in the archives.

To test:

  • Check out this PR as well as feat(diagnostics): Add GraphQL support for thread dumps cryostat#1051
  • Build everything and run smoketest with quarkus cryostat agent:
    bash smoketest.bash -O -t quarkus-cryostat-agent
  • Test out the thread and heap dump base functionality
  • Trigger a thread and heap dump from both the diagnostics card as well as the capture diagnostics page
  • Check the target specific view for each (Analyze heap dumps and analyze thread dumps) and make sure the table renders and works as expected
  • De-select the target to get the all-targets view
  • Verify that the expected targets show up and the dumps for each are accessible

@github-actions
Copy link
Copy Markdown

This PR/issue depends on:

@Josh-Matsuoka Josh-Matsuoka added the feat New feature or request label Sep 19, 2025
@andrewazores
Copy link
Copy Markdown
Member

A few things I noticed:

  1. when I create a thread dump, the notification text looks like: Thread Dump c5864e6e-23e2-4c6b-a4fe-c612f9f37f4b created for target: undefined. I think this is supposed to be the target alias or connection URL, not undefined.
  2. when I go to the Analyze > Thread Dumps or Heap Dumps views and select a specific target, then delete a dump file, I get a success notification but the table does not seem to update
  3. when I am on those same table views and clear the target selection so that I get the new All Targets table state, deletion fails with an HTTP 404 - or sometimes the Delete action item seems to be unclickable

@andrewazores andrewazores merged commit a356a38 into cryostatio:main Oct 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request] All Targets view for Diagnostics

2 participants