Use frontend plugin to build web-client #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also based on top of #130 |
andrewazores
force-pushed
the
frontend-plugin
branch
2 times, most recently
from
d1ba683 to
54f1b71
Compare
Use specific "frontend" plugin for building -web submodule, rather than invoking "exec" plugin directly
andrewazores
force-pushed
the
frontend-plugin
branch
from
54f1b71 to
d859a83
Compare
|
Rebased |
ebaron
reviewed
Mar 9, 2020
ebaron
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "frontend" plugin is a nice improvement over directly using the exec plugin
to invoke "npm" for building the web-client. For one thing, the intent is more
clear. But the real advantage is that the frontend plugin will automatically
download and install Node and npm binaries into the bin directory, removing
the need for developers (or CI servers) to install Node and npm in order to
build container-jfr. This also keeps versions consistent and makes builds more
reproducible. These additional binaries will be removed on
mvn clean, andare also cached in
.m2, so the build time impact is very minimal after the firstrun.