Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webserver): password length and username can be configured #367

Merged
merged 15 commits into from
Apr 12, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 4, 2024

Fixes #341

  • makes the webserver credential username configurable. Defaults to user as before, but this can be overridden if some need arises.
  • makes the webserver credential password length configurable. This is always randomly generated, but the length was previously hardcoded to 24 characters. Now this can be configured, but continues to default to 24.
  • expands the set of characters that can be generated for the password to include more of the ASCII symbols set. This increases password strength. Also simplifies the logic to just fill the password with any printable ASCII character, instead of trying to require at least one character from each of specific ranges first and then filling the remainder.

@andrewazores andrewazores added feat New feature or request safe-to-test labels Apr 4, 2024
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Apr 4, 2024
@andrewazores andrewazores requested a review from mwangggg April 4, 2024 19:29
@andrewazores andrewazores force-pushed the configure-auth-user branch from 12651d3 to ffe3e33 Compare April 4, 2024 19:30
@andrewazores andrewazores added docs needs-documentation ready-for-documentation and removed needs-triage Needs thorough attention from code reviewers labels Apr 4, 2024
@andrewazores andrewazores force-pushed the configure-auth-user branch from f6d3f28 to bb8a0b0 Compare April 5, 2024 23:00
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just needs a rebase

@andrewazores andrewazores merged commit 0f19151 into cryostatio:main Apr 12, 2024
9 checks passed
@andrewazores andrewazores deleted the configure-auth-user branch April 12, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Basic auth user should be configurable
2 participants