Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(registration): do not restart harvester on refresh #29

Merged
merged 4 commits into from
Jan 5, 2023
Merged

fix(registration): do not restart harvester on refresh #29

merged 4 commits into from
Jan 5, 2023

Conversation

andrewazores
Copy link
Member

Fixes #28

  • fix(registration): do not restart harvester on refresh
  • ignore start request if already started
  • log template and period on start
  • fixup! fix(registration): do not restart harvester on refresh

@andrewazores andrewazores requested a review from tthvo December 23, 2022 21:25
tthvo
tthvo approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Worked as expected :D

@andrewazores andrewazores merged commit 4a350ba into cryostatio:main Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo approved these changes

Assignees
No one assigned
Labels
fix
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Discovery plugin ping reregistration triggers recording cancellation
2 participants
@andrewazores @tthvo