Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(recordings): add InvalidEventTemplateException for bad start recording requests #198

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

mwangggg
Copy link
Member

fixes: #174

@mwangggg mwangggg added chore Refactor, rename, cleanup, etc. safe-to-test labels Sep 19, 2023
@mwangggg mwangggg force-pushed the 174-Invalid-Event-Template branch from 0351c9f to 96b1e2c Compare September 19, 2023 18:23
Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to wait for a -core release to include cryostatio/cryostat-core#259

@mwangggg mwangggg force-pushed the 174-Invalid-Event-Template branch from 6f1cd6a to d7f9809 Compare September 19, 2023 18:39
@andrewazores
Copy link
Member

This will need to wait for a -core release to include cryostatio/cryostat-core#259

https://github.com/cryostatio/cryostat-core/packages/1756509

https://github.com/cryostatio/cryostat-core/releases/tag/v2.23.0

@mwangggg mwangggg force-pushed the 174-Invalid-Event-Template branch from d7f9809 to 79a8b44 Compare September 27, 2023 15:19
@mwangggg mwangggg requested a review from ebaron as a code owner September 27, 2023 15:23
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@andrewazores andrewazores force-pushed the 174-Invalid-Event-Template branch from 38f8c69 to 3cb9c3a Compare September 27, 2023 17:37
@andrewazores andrewazores merged commit a584f82 into cryostatio:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] Throw InvalidEventTemplateException on bad recording start request
3 participants