Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widevine Component #58

Merged
merged 4 commits into from
Nov 13, 2019
Merged

Widevine Component #58

merged 4 commits into from
Nov 13, 2019

Conversation

NootThePenguin
Copy link
Contributor

@NootThePenguin NootThePenguin commented Nov 12, 2019

This allows the Netflix player to work, it's currently using a beta version of widevine. (I've tried multiple versions and it has to be this one)

Closes #43

This allows the Netflix player to work, it's currently using a beta version of widevine. (I've tried multiple versions and it has to be this one)
Copy link
Contributor

@plusreed plusreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me (I can't test the functionality, unfortunately) but I do have a little suggestion in terms of the documentation.

@69

This comment has been minimized.

@69
Copy link

69 commented Nov 12, 2019

Cleaned up the snippet a bit and made so it fetches the latest version automatically:

# Install Widevine component for Chromium
RUN WIDEVINE_VERSION=$(wget --quiet -O - https://dl.google.com/widevine-cdm/versions.txt | tail -n 1) && \
    wget "https://dl.google.com/widevine-cdm/$WIDEVINE_VERSION-linux-x64.zip" -O /tmp/widevine.zip && \
    unzip -p /tmp/widevine.zip libwidevinecdm.so > /usr/lib/chromium/libwidevinecdm.so && \
    chmod 644 /usr/lib/chromium/libwidevinecdm.so && \
    rm /tmp/widevine.zip

Copy link
Contributor

@plusreed plusreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me!
@williamsthing What is your final say? LGTM?

Copy link
Member

@JeDaYoshi JeDaYoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to go! And works. 👀

@JeDaYoshi
Copy link
Member

Thanks for your contribution -- I'll merge it now!

@JeDaYoshi JeDaYoshi merged commit 7680f32 into crybapp:master Nov 13, 2019
Soliel added a commit to SolCryb/portal that referenced this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Browser Components Preventing Netflix From Playing
5 participants