-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widevine Component #58
Conversation
This allows the Netflix player to work, it's currently using a beta version of widevine. (I've tried multiple versions and it has to be this one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me (I can't test the functionality, unfortunately) but I do have a little suggestion in terms of the documentation.
This comment has been minimized.
This comment has been minimized.
Cleaned up the snippet a bit and made so it fetches the latest version automatically: # Install Widevine component for Chromium
RUN WIDEVINE_VERSION=$(wget --quiet -O - https://dl.google.com/widevine-cdm/versions.txt | tail -n 1) && \
wget "https://dl.google.com/widevine-cdm/$WIDEVINE_VERSION-linux-x64.zip" -O /tmp/widevine.zip && \
unzip -p /tmp/widevine.zip libwidevinecdm.so > /usr/lib/chromium/libwidevinecdm.so && \
chmod 644 /usr/lib/chromium/libwidevinecdm.so && \
rm /tmp/widevine.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me!
@williamsthing What is your final say? LGTM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to go! And works. 👀
Thanks for your contribution -- I'll merge it now! |
Add Widevine Component (crybapp#58)
This allows the Netflix player to work, it's currently using a beta version of widevine. (I've tried multiple versions and it has to be this one)
Closes #43