-
Notifications
You must be signed in to change notification settings - Fork 63
Add --threads
(-t
) option to downloading commands
#256
Add --threads
(-t
) option to downloading commands
#256
Conversation
This could be extended to be a command to specify the thread count instead of only single threaded |
True, that'd be pretty easy, but do you mean a command or an option? I feel like an option would make more sense. |
Yes an option/flag. So instead of |
Okay, sure, I'll do that later today 👍 |
--single-threaded
(-t
) option to downloading commands--threads
(-t
) option to downloading commands
Done :) |
Okay nice. Just one more thing which came me in mind. Instead of the flag being |
You got it 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) 👍
This PR adds a
threads
field toDownloadBuilder
andDownloader
and adds a--threads
(or-t
for short) option to thedownload
andarchive
commands. This overrides the cores thatDownloader
utilizes for downloading. This is useful in situations such as my own where having one program utilize all cores for downloading renders the rest of the device practically unusable. I understand that the name--threads
might not be entirely accurate as to what it does since I think the number of threadstokio
uses is the same to some extent even with this new option, so I'm open to suggestions for a more accurate name.