Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Implement hardsub without post-processing soft sub #268

Closed
OctoCharm opened this issue Nov 19, 2023 · 3 comments
Closed

Implement hardsub without post-processing soft sub #268

OctoCharm opened this issue Nov 19, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@OctoCharm
Copy link

As we know, CR has two kinds of streams: a video with a soft sub (mostly used on browsers and mobile phones) and a video with a hard sub (mostly used on OTT [Android TV, Apple TV, Roku TV, Amazon Fire TV, Windows Apps]).

Using these current algorithms is not efficient and wasteful of computing resources.

  1. Download the video track
  2. Download the audio track
  3. Download the subtitle
  4. Remux all the tracks (video, audio, subtitle) using FFmpeg

Instead of directly downloading a hard subbed version from CR without performing any post-processing, such as rendering the soft sub into a hard sub.

image

@OctoCharm OctoCharm added the enhancement New feature or request label Nov 19, 2023
@bytedream
Copy link
Member

We originally did this, but streams with hard-subbed episodes aren't always available (#81 (comment)).
To lower maintenance time, I've kicked them completely out in favor of manual burning. But I think this can be re-added with manual burning only necessary if the requested hardsubs doesn't already exist.

@OctoCharm
Copy link
Author

OctoCharm commented Nov 19, 2023

Sure, it would be better to use manual burning (a.k.a post-processing soft-sub) as a fallback, not a primary one.

@bytedream
Copy link
Member

Implemented in v3.1.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants