GLTFScene: basic support for KHR_materials_pbrSpecularGlossiness extension #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhsaez
approved these changes
May 26, 2021
There was a problem hiding this comment.
These changes look good to me. Although, like you mentioned in the description, the end result might not look correct, since we don't really have support for any lighting model.
Thanks for adding the extra fixes as well!
I'm not sure how to fix the CI errors, though. I'll ask around.
jtbandes
added a commit
to foxglove/regl-worldview
that referenced
this pull request
Oct 15, 2021
Make it possible to import GLText in tests (but not use it) by adding a `typeof self` check before accessing `self`. Also import a couple of small fixes to parseGLB and GLTFScene from cruise-automation/webviz#625 that were never merged.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
material.extensions.KHR_materials_pbrSpecularGlossinessby using thediffuseTexturein place of thepbrMetallicRoughness.baseColorTexture. This is not a perfect/complete implementation, however, it's better than having no support at all for pbrSpecularGlossiness!Other small fixes:
wrapSandwrapTdefaults to REPEAT as described in https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#samplerbyteOffsetdefault to 0 as described in https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#accessorExample model from: SpecGlossVsMetalRough
The two bottles are supposed to look identical, so obviously this is not a complete rendering implementation.