Mono8 support #165
Closed
Mono8 support #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
reviewed
Jul 1, 2019
jtbandes
reviewed
Jul 1, 2019
Co-Authored-By: Jacob Bandes-Storch <[email protected]>
Co-Authored-By: Jacob Bandes-Storch <[email protected]>
jtbandes
reviewed
Jul 2, 2019
jtbandes
reviewed
Jul 2, 2019
jtbandes
reviewed
Jul 2, 2019
| let outIdx = 0; | ||
|
|
||
| for (let i = 0; i < width * height; i++) { | ||
| const val = !is_bigendian ? mono16[inIdx] : mono16[inIdx - 1]; |
There was a problem hiding this comment.
Did you try ... : mono16[inIdx + 1] instead? I think inIdx - 1 is wrong because at the beginning, it will be mono16[-1].
Co-Authored-By: Jacob Bandes-Storch <[email protected]>
jtbandes
approved these changes
Jul 3, 2019
| @@ -15,27 +15,27 @@ | |||
| "regenerator-runtime": { | |||
There was a problem hiding this comment.
Would be nice to revert these changes since they aren't relevant to the PR.
|
Merging PR to internal repo, will be out to open source repo in a future push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image panel support for mono8, details can be found in this convo: #161 (comment)
source of sample bag: https://www.cse.unr.edu/~kalexis/datasets/thermal-inertial/
Btw encountered some weirdness with /packages/@cruise-automation not being found. Assuming it was an issue with my fork/local npm but flagging just in case