New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass number instead of string into Buffer.indexOf #88

Merged

brianc merged 1 commit into cruise-automation:master from gkjohnson:patch-1

Oct 28, 2020

Contributor

gkjohnson commented Oct 26, 2020

Fix #87


          Pass number instead of string into Buffer.indexOf

7f01cbd

brianc reviewed

View reviewed changes

src/fields.js

@@ @@ -27,8 +28,10 @@ export function extractFields(buffer: Buffer) { @@
                     throw new Error("Header fields are corrupt.");
                   }
+                  // Passing a number into "indexOf" explicitly to avoid Buffer polyfill
+                  // slow path. See issue #87.

Contributor

brianc Oct 27, 2020

👍 great comment to help remember why the code is the way it is.

brianc approved these changes

View reviewed changes

brianc merged commit 182ac62 into cruise-automation:master

Stuk pushed a commit that referenced this pull request


          Pass number instead of string into Buffer.indexOf (#88)

29b4140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet