Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Add default call to createConvertTorchToTcpPass #18

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Add default call to createConvertTorchToTcpPass #18

merged 1 commit into from
Nov 5, 2023

Conversation

sjain-stanford
Copy link
Collaborator

Slightly improves user-interface by allowing pipelines to add the default ConvertTorchToTcpPass without an empty ArrayRef:

-  pm.addNestedPass<func::FuncOp>(tcp::createConvertTorchToTcpPass({}));
+  pm.addNestedPass<func::FuncOp>(tcp::createConvertTorchToTcpPass());

@sjain-stanford sjain-stanford marked this pull request as ready for review November 4, 2023 16:38
@sjain-stanford sjain-stanford requested review from sanjoy, a team and navahgar November 4, 2023 16:39
@sjain-stanford sjain-stanford merged commit 6070960 into cruise-automation:main Nov 5, 2023
@sjain-stanford sjain-stanford deleted the sambhav/signature branch November 5, 2023 04:15
srinathava pushed a commit to srinathava/mlir-tcp that referenced this pull request Jun 24, 2024
TCP Upgrade (cruise-automation#18)
c78a73e 
[LLVM](https://github.com/llvm/llvm-project/tree/a952c123880eb1168f1021b116485e27170d48ca)
(April 11)

[Torch-MLIR](https://github.com/llvm/torch-mlir/tree/45eaeaaf3640f1f7f7b4743cf5844c3b9d519fdf)
(April 12)

[StableHlo](https://github.com/openxla/stablehlo/tree/271e8634de184fbfafd677d3876170feb6d08c97)
(March 28)

[TCP](https://github.com/cruise-automation/mlir-tcp/tree/04f327c698dd6f588ce09d8d9c99533c1e9855f9)
(April 12)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sanjoy sanjoy sanjoy approved these changes

@navahgar navahgar Awaiting requested review from navahgar

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjain-stanford @sanjoy