Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.14 #26

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Update to go 1.14 #26

merged 1 commit into from
Mar 11, 2020

Conversation

jonnylangefeld
Copy link
Contributor

  • use distroless docker image for final stage
  • run go mod vendor

@jonnylangefeld jonnylangefeld force-pushed the update-to-go-1-14 branch 2 times, most recently from c0d7e26 to 4763935 Compare March 10, 2020 00:44
@cxuu
Copy link
Contributor

cxuu commented Mar 10, 2020

Thanks for your contribution!

Could you also update our CI config so we are testing with go.1.14 as well?

@jonnylangefeld
Copy link
Contributor Author

@cxuu good point, seemed to be a version miss match before too (1.12 in ci vs. 1.11 in the docker image), that's why I didn't find it.
The circleci/golang images seem to be legacy anyway, i updated it to the next gen image.

@jonnylangefeld jonnylangefeld mentioned this pull request Mar 10, 2020
Open
@cxuu
Copy link
Contributor

cxuu commented Mar 10, 2020

I just slacked you but it seems slack was not fully setup for you. Could you rebase from master again? I just made a few commits. Thanks!

@jonnylangefeld jonnylangefeld force-pushed the update-to-go-1-14 branch 2 times, most recently from c0a93db to 95267fb Compare March 11, 2020 00:27
@jonnylangefeld
Update to go 1.14
477a08b 
* use [distroless](https://github.com/GoogleContainerTools/distroless) docker image for final stage
* run `go mod vendor`
@jonnylangefeld
Copy link
Contributor Author

Yes, exactly. I'm a new hire since this week and since we're all working from home, they'll send me a laptop in the mail tomorrow :)
Rebase is done!

@cxuu cxuu merged commit ba07935 into cruise-automation:master Mar 11, 2020
@jonnylangefeld jonnylangefeld deleted the update-to-go-1-14 branch March 11, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cxuu cxuu cxuu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnylangefeld @cxuu