feat(electron): mount the unified workbench shell behind a flag (0406) - #651
Merged
Conversation
added 3 commits
July 28, 2026 16:12
…kage (0406) Signed-off-by: xNet Test <test@xnet.dev>
The desktop implements WorkbenchHost (real tags + Space-aware creation through the port; explicit not-on-desktop-yet panels for comms, habits and share links) and registers its hosted-view table (real PageView and DatabaseView; visible placeholders elsewhere). With localStorage xnet:unified-shell=1 the shared <Workbench/> renders instead of the bespoke shell — verified live over real SQLite: sidebar islands, explorer rows from the desktop store, port navigation into the real page editor, and the ⌘K palette searching native data. Also: sidebar channel rows degrade via useCommsMaybe instead of throwing on hosts without a comms layer. Signed-off-by: xNet Test <test@xnet.dev>
…ce renderer load (0406) Signed-off-by: xNet Test <test@xnet.dev>
Contributor
|
✓ Changelog fragment found — thanks! |
Contributor
🖼️ UI changes in this PRWarning 1 changed UI file(s) map to no capture target. Unmapped files
|
Contributor
|
Preview removed for PR #651. |
crs48
added a commit
that referenced
this pull request
Jul 29, 2026
#652) Exploration 0406, the increment after #651: the desktop differentiators now live inside the shared shell. - **Hosted views**: `canvas`, `meetings`, and `data` resolve to the real desktop components (port-navigating wrappers) instead of "not on desktop yet" panels. - **Canvas home stays the default surface** inside `<Workbench/>` — full home wiring (ref, pending inserts, create handlers), per the exploration's open question 1 ("default preset, not a different shell"). - The unified shell's children slot now renders every ShellState: meetings, data workspace, social import, settings, assistant, stories. - **Port**: `/social-import` path intent resolves on desktop (the workbench sidebar's Import row was a dead click before). - **Capability gating**: AiChatPanel's preload bridge control now flows through `PlatformPort.capabilities.agentBridge` — the last direct `window.xnet*` sniff in the shared package is gone. Verified live in Electron under `xnet:unified-shell=1`: canvas home renders with real nodes, sidebar Import → Social Import (importer registry), Meetings list, palette "Go to data workspace" → Data Workspace, assistant panel auto-pairs the bridge ("Running claude · v3.0.0") with the agent-switch control present. Zero console errors. Checklist: +2 implementation items (18→20 of 23). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
crs48
added a commit
that referenced
this pull request
Jul 29, 2026
Every box in exploration 0406 is checked — 23/23 implementation, 10/10 validation — so the filename flips to `[x]`. The arc, for the record: #641/#642/#644 (port + core extraction), #648 (AI panel on desktop), #650/#651 (chrome behind injection points, first Electron mount), #652 (desktop surfaces in the shell), #653 (flag removed, bespoke shell deleted), #655 (cold-open back under the 0.52s baseline), #656 (approval-gated writes — the last blocked item). The desktop and web apps now render one shell from one module, verified live at every step. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The desktop half of exploration 0406's mount phase, stacked on #650:
Verified live in Electron over real SQLite
Sidebar islands, lens chips, and the explorer listing the desktop store's real pages; clicking a row navigates through the port into the real desktop PageView; the ⌘K palette (the moved GlobalSearch) searches native data ("Electron Smoke Page") — zero console errors.
Measurements (checklist item)
Exploration 0406 is now 18/23 implementation. Remaining: register canvas home/meetings/social-import as workbench views, capability gating, flag removal + bespoke-shell deletion, and the 0394-gated panel-write item.
🤖 Generated with Claude Code