feat(electron): the desktop host implements the PlatformPort (0406) - #649
Merged
Conversation
Adds useDesktopPlatformPort (0406 phase 3): NavTarget intents resolve to ShellState transitions through the shell's own handlers — home restores the viewport, documents go through type lookup and the canvas glide — and the pathname is synthesized in web's route grammar so shared core modules (tabFromPathname, route titles) behave identically on both hosts. Unhandled targets return false and the port warns loudly — the silent dead click is the failure mode 0406 exists to kill. Six unit tests pin the pathname grammar and dispatch table; verified live that the provider mounts and the shell + Assistant behave unchanged. This is the desktop's half of the seam #641 defined: the moment shared chrome mounts here, its navigation already works. Signed-off-by: xNet Test <test@xnet.dev>
Contributor
🖼️ UI changes in this PRNo visual differences detected in the changed UI. |
Contributor
|
Preview removed for PR #649. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues exploration 0406 (14/33 after this). The desktop's half of the seam #641 defined.
useDesktopPlatformPortresolvesNavTargetintents toShellStatetransitions through the shell's own handlers (home restores the viewport; documents go through type lookup and the canvas glide), and synthesizes pathnames in web's route grammar so shared core modules (tabFromPathname, route titles) behave identically on both hosts. Unhandled targets returnfalseand warn loudly — the silent dead click is the failure mode this exploration exists to kill.PlatformProvidernow wraps the desktop shell tree: the moment shared chrome mounts here, its navigation already works.Verification: 6 new unit tests pin the pathname grammar and dispatch table (155 electron total, all green); typecheck clean; verified live over CDP that the provider mounts and the shell + Assistant behave unchanged.
skip-changelog: internal plumbing, no user-visible change.🤖 Generated with Claude Code