feat(tasks): add inline assignees and due dates to page tasks #4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| name: Deploy PR Preview | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| concurrency: | ||
| group: pages-branch | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| deploy-preview: | ||
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
|
|
||
| - uses: ./.github/actions/setup | ||
|
|
||
| - name: Build packages | ||
| run: pnpm build | ||
|
|
||
| - name: Build web app preview | ||
| run: pnpm --filter xnet-web build | ||
| env: | ||
| VITE_BASE_PATH: /pr/${{ github.event.pull_request.number }}/app/ | ||
| VITE_USE_HASH_ROUTER: 'true' | ||
|
|
||
| - name: Prepare preview tree | ||
| run: | | ||
| rm -rf /tmp/xnet-pr-preview | ||
| mkdir -p /tmp/xnet-pr-preview | ||
| cp -R apps/web/dist/. /tmp/xnet-pr-preview/ | ||
| cp /tmp/xnet-pr-preview/index.html /tmp/xnet-pr-preview/404.html | ||
|
|
||
| - name: Publish preview to gh-pages | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| rm -rf /tmp/xnet-gh-pages | ||
| git fetch origin gh-pages || true | ||
|
|
||
| if git ls-remote --exit-code --heads origin gh-pages >/dev/null 2>&1; then | ||
| git worktree add -B gh-pages /tmp/xnet-gh-pages origin/gh-pages | ||
| else | ||
| git worktree add -B gh-pages /tmp/xnet-gh-pages HEAD | ||
| find /tmp/xnet-gh-pages -mindepth 1 -maxdepth 1 ! -name '.git' -exec rm -rf {} + | ||
| cp site/public/CNAME /tmp/xnet-gh-pages/CNAME | ||
| touch /tmp/xnet-gh-pages/.nojekyll | ||
| fi | ||
|
|
||
| preview_dir="/tmp/xnet-gh-pages/pr/${{ github.event.pull_request.number }}/app" | ||
| mkdir -p "$preview_dir" | ||
| rsync -a --delete /tmp/xnet-pr-preview/ "$preview_dir/" | ||
|
|
||
| cd /tmp/xnet-gh-pages | ||
| git add -A | ||
|
|
||
| if git diff --cached --quiet; then | ||
| echo "No preview changes to publish." | ||
| exit 0 | ||
| fi | ||
|
|
||
| git commit -m "deploy(preview): publish PR #${{ github.event.pull_request.number }} preview" | ||
| git push origin HEAD:gh-pages | ||
|
|
||
| - name: Comment preview link | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const body = [ | ||
| '<!-- xnet-pr-preview -->', | ||
| `Preview: https://xnet.fyi/pr/${context.payload.pull_request.number}/app/` | ||
| ].join('\n') | ||
|
|
||
| const comments = await github.paginate(github.rest.issues.listComments, { | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.payload.pull_request.number | ||
| }) | ||
|
|
||
| const existing = comments.find((comment) => | ||
| comment.user?.login === 'github-actions[bot]' && | ||
| comment.body?.includes('<!-- xnet-pr-preview -->') | ||
| ) | ||
|
|
||
| if (existing) { | ||
| await github.rest.issues.updateComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| comment_id: existing.id, | ||
| body | ||
| }) | ||
| return | ||
| } | ||
|
|
||
| await github.rest.issues.createComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.payload.pull_request.number, | ||
| body | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| name: Remove PR Preview | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [closed] | ||
|
|
||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| concurrency: | ||
| group: pages-branch | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| remove-preview: | ||
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Remove preview from gh-pages | ||
| run: | | ||
| git config user.name "github-actions[bot]" | ||
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| rm -rf /tmp/xnet-gh-pages | ||
| git fetch origin gh-pages || true | ||
|
|
||
| if ! git ls-remote --exit-code --heads origin gh-pages >/dev/null 2>&1; then | ||
| echo "gh-pages branch does not exist yet." | ||
| exit 0 | ||
| fi | ||
|
|
||
| git worktree add -B gh-pages /tmp/xnet-gh-pages origin/gh-pages | ||
|
|
||
| target="/tmp/xnet-gh-pages/pr/${{ github.event.pull_request.number }}" | ||
|
|
||
| if [ ! -d "$target" ]; then | ||
| echo "Preview path already absent." | ||
| exit 0 | ||
| fi | ||
|
|
||
| rm -rf "$target" | ||
|
|
||
| cd /tmp/xnet-gh-pages | ||
| git add -A | ||
|
|
||
| if git diff --cached --quiet; then | ||
| echo "No preview cleanup changes to publish." | ||
| exit 0 | ||
| fi | ||
|
|
||
| git commit -m "deploy(preview): remove PR #${{ github.event.pull_request.number }} preview" | ||
| git push origin HEAD:gh-pages | ||
|
|
||
| - name: Comment preview removal | ||
| uses: actions/github-script@v7 | ||
| with: | ||
| script: | | ||
| const body = [ | ||
| '<!-- xnet-pr-preview -->', | ||
| `Preview removed for PR #${context.payload.pull_request.number}.` | ||
| ].join('\n') | ||
|
|
||
| const comments = await github.paginate(github.rest.issues.listComments, { | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.payload.pull_request.number | ||
| }) | ||
|
|
||
| const existing = comments.find((comment) => | ||
| comment.user?.login === 'github-actions[bot]' && | ||
| comment.body?.includes('<!-- xnet-pr-preview -->') | ||
| ) | ||
|
|
||
| if (existing) { | ||
| await github.rest.issues.updateComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| comment_id: existing.id, | ||
| body | ||
| }) | ||
| return | ||
| } | ||
|
|
||
| await github.rest.issues.createComment({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: context.payload.pull_request.number, | ||
| body | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared concurrency group cancels cross-workflow deployments
All four workflows (
deploy-pr-preview.yml,deploy-site.yml,remove-pr-preview.yml,undeploy-site.yml) sharegroup: pages-branchwithcancel-in-progress: true. This means a push tomainwill cancel any in-flight PR preview deployment (and vice versa).In the worst case: a PR preview run is mid-way through the
rsync+git addsteps when amainpush triggers the site deploy and cancels it. The gh-pages worktree at/tmp/xnet-gh-pagesis abandoned mid-edit, but since the push hadn't happened yet, the remotegh-pagesbranch is unaffected. The PR preview simply never gets published, with no error surfaced to the PR author.A safer pattern is to use separate concurrency groups for PR previews and site deploys — they both operate on
gh-pagesbut write to distinct subdirectories (/pr/<N>/vs everything else):The
rsync --exclude prindeploy-site.ymlandrsync -a --deleteinside/pr/<N>/in the preview workflows already keep them isolated at the file level, so separate groups would not introduce write conflicts.This same issue is present in
.github/workflows/remove-pr-preview.yml(line 17) and.github/workflows/undeploy-site.yml(line 12).