Improve pages editor markdown UX - #23
Merged
Merged
Conversation
- Map current Tiptap/Yjs editor architecture - Compare Markdown-first and block editor alternatives - Recommend a phased rewrite and validation plan
- Add MarkdownStructuralEditing for heading token Backspace behavior - Demote headings one level at a time before converting to paragraph - Cover structural Backspace guards with focused Vitest tests - Check off completed exploration items
- Add setHeading and toggleHeading commands to HeadingWithSyntax - Keep heading toolbar and slash commands working with custom heading nodes - Cover command behavior with focused editor tests
- Focus the editor when users click blank page body space - Add a centered writing column with more vertical editing room - Mark completed page surface exploration checklist items
- Add code block commands to the custom code block node view extension - Add blockquote commands to the custom blockquote node view extension - Cover toolbar button routing and custom block command behavior with focused tests
- Notify onEditorReady once for each editor instance - Add regression coverage for parent re-renders with changing callback identity - Verify the editor Storybook smoke surface renders without the previous update-depth loop
- Resolve blank page-surface clicks to the first block or document end by pointer position - Add focused unit coverage for page editor focus targeting - Check off the exploration focus-target milestone
- Unwrap custom blockquotes when Backspace consumes the visible quote token - Preserve heading-token demotion before quote unwrapping inside blockquotes - Cover start-of-block and inside-text blockquote Backspace behavior
- lift bullet and ordered list items from the start of their first text block - exit top-level task items while preserving task text - cover nested list lifts and non-start backspace fallthrough
- clear code block language before removing the fenced block - convert plaintext code blocks back into paragraph content at the fence boundary - preserve multiline code content with a trailing insertion paragraph
- centralize page, mobile, read, and canvas toolbar visibility decisions - expose toolbarSurface on RichTextEditor and route canvas inline pages to compact toolbar behavior - cover toolbar policy and compact canvas selection rendering with focused tests
- add a small absolute timing margin to the batch signing benchmark - relax Level 0 verification caps for shared pre-commit load - keep crypto performance assertions as broad regression guards
- replace built-in text and inline svg toolbar glyphs with lucide icons - add aria labels to icon buttons while preserving titles and focus behavior - add lucide-react as an explicit editor package dependency
- add the official Tiptap Markdown extension to the page editor - provide Markdown parse and render specs for custom heading, quote, and code block nodes - cover GFM parsing and Markdown round trips for structural page content - clamp calendar month navigation so month-end dates do not break the commit suite
- add a Markdown clipboard extension for plain-text markdown paste - serialize copied structural selections as markdown text - keep rich HTML payloads and plain URLs available to existing paste handlers
- add a declarative Markdown token contract and test matrix - cover heading, quote, list, task, and code-fence input rules - keep structural Backspace steps composition-safe and separately undoable
- add xNet-flavored Markdown directives for database and media embeds - add inline smart-reference and wikilink Markdown round trips - cover custom embed parse and serialization behavior with editor tests
- reveal inline mark syntax at both opening and closing boundaries - mark syntax widgets as selection-relaxed to avoid caret trapping - document covered inline mark behavior in the Markdown token contract
- add live source and read mode policy helpers - render a Markdown source textarea when source mode is requested - hide rich-editor toolbar affordances outside live editing mode
- store source markdown metadata for parsed xnet JSON directives - reuse authored database media and smart reference syntax while attrs stay unchanged - fall back to canonical serialization after semantic edits
- add a shared data-layer embed registry facade for provider iframe policies - route canvas embed policy helpers through the shared registry - cover provider allowlists arbitrary embeds and spoofed hosts with unit tests
- insert block preview cards for bare generic URL pastes - keep embeddable provider URLs on the media embed path - seed Storybook with a generic rich-link card for browser smoke coverage
- define inline block compact and read-only renderer support per provider - expose renderer mode metadata through external-reference card descriptors - cover generic links and live media mode declarations in tests
- make database embeds explicitly selectable and isolating block atoms - add keyboard exits for selected embeds using arrow and enter shortcuts - limit drag handles to embed headers so controls and view content stay interactive
- add a selectable page embed node with a React card view - wire page embeds into RichTextEditor exports Markdown serialization and slash commands - cover page embed commands HTML rendering and xNet Markdown round trips
- assert origin-blocked canvas cards render fallback UI without iframes - cover provider-origin fallback descriptors alongside provider blocks - mark blocked-origin and blocked-provider validation complete in the exploration
- check off the provider iframe smoke item after browser verification - verified YouTube Vimeo Loom Figma and CodeSandbox in Storybook - kept the verification manual to follow repository guidance against UI test files
- check off the full @xnetjs/editor test validation item - record completion after 50 files and 605 tests passed - keep the implementation checklist aligned with completed verification
- render page and note canvas cards as low-zoom static document previews - add direct peek and open actions without requiring prior selection - keep embedded editor pointer interactions from moving Canvas V3 nodes - cover preview model and editor-surface drag isolation with tests
- add a deterministic DOM island budget test for 500 page cards - assert live, shell, iframe, and parked object caps for high-zoom page previews - check off the Phase 5 page-card performance budget item
- Add Yjs multi-client regressions for concurrent heading token edits - Cover local collaboration undo/redo and remote cursor decorations - Verify comment anchors survive Markdown structural transforms - Check off collaboration validation items in the exploration
- Mark the Tiptap path decision after Markdown and Yjs collaboration coverage - Record the editor performance validation bundle - Add the latest in-app browser Storybook smoke result
- Add a shared page editor rollout mode storage key - Allow editable page and canvas-inline surfaces to fall back to source or read mode - Export the rollout helpers for app-level controls - Check off the rollout kill-switch item in the exploration
- keep desktop BubbleMenu registered so selection-driven toolbar display works in the app shell - expose shortcut-aware toolbar title hints without lengthening accessible button names - add e2e coverage for Markdown heading backspace, slash task insertion, and toolbar hints - update the pages editor exploration with minimalist tooltip, popover, and shortcut requirements
- render toolbar hints with the shared design-system tooltip primitive - keep toolbar buttons icon-only with short accessible names and shortcut kbd hints - assert the visible Bold tooltip in the Markdown editor e2e flow - check off the completed tooltip requirements in the exploration
- Add a compact Link popover with URL input and apply/remove controls. - Keep the BubbleMenu visible while the popover owns focus. - Avoid clipping the popover in compact and mobile toolbar layouts. - Cover link apply, remove, and Escape behavior with unit tests. - Add Markdown e2e coverage and update the exploration checklist.
- Add a compact Reference popover for inline page wikilinks. - Prefill the reference input from the selected editor text. - Keep the toolbar mounted while the reference input owns focus. - Cover insert, Escape, and focus behavior with unit tests. - Add browser e2e coverage and update the exploration checklist.
- add a compact database embed popover with view-mode selection and picker support - keep the floating toolbar visible while database popover controls own focus - cover insert, validation, Escape, picker, and e2e database embed flows - update the pages editor exploration checklist and UI requirements
- add a compact toolbar popover for supported rich media embed URLs - validate empty and unsupported media URLs without mutating editor content - keep the floating toolbar visible while media popover controls own focus - cover media insertion with unit tests, e2e, and exploration checklist updates
- add browser coverage for dismissing slash commands with Escape - assert Escape does not insert checklist controls or run a block command - check off the slash Escape validation item in the exploration
- replace the Mod-K prompt path with a scoped toolbar popover event - keep shortcut-triggered link editing isolated to the matching editor instance - cover shortcut dispatch, toolbar event handling, browser flow, and exploration checklist notes
- replace slash page and database prompt fallbacks with inline setup surfaces - let page and database embed node views configure missing targets in place - cover promptless slash setup with unit tests, e2e flows, and exploration checklist updates
- add an inline databaseReference node with xNet markdown round-trip support - extend the Reference popover with page and database modes - cover database references with unit tests, e2e flow, and exploration checklist updates
- add a typed JSON normalizer for legacy editor documents - convert old page, database, media, and db reference nodes - preserve editable fallback text and update rollout checklist
- keep DevTools closed during auth-bypassed Electron tests - expose Canvas V3 theme and legacy node diagnostics - use pointer events in the Electron canvas selection helper
- assert page editor surfaces default to live rich editing - document the new-page rollout checkpoint
- record browser page CRUD validation with auth bypass - check off all-pages rollout after shared PageView validation
- Rename exploration 0137 from unchecked to checked status - Preserve the completed implementation notes and checklist history
- Add live-preview key handling for arrow movement across inline mark delimiters - Let Backspace/Delete at virtual delimiters unwrap marks without deleting text - Extend markdown token contract, focused unit coverage, e2e coverage, and exploration checklist
- Treat Backspace/Delete at inline markdown boundaries as delimiter deletion - Preserve marked text while removing bold, italic, strike, or code marks - Add focused unit and browser regression coverage for boundary deletion
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughAdds EditorSurface with content-mode rollout and error boundary, migrates PageView and inline canvas editor, introduces Markdown IO, structural editing, and multiple extensions (page/database embeds, rich link, references), refactors canvas previews/peek, centralizes embed policies via data registry, updates canvas renderer, styles, tests, and E2E flows. ChangesEditor surfaces, markdown, and canvas previews
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
Contributor
|
Preview removed for PR #23. |
crs48
added a commit
that referenced
this pull request
Aug 13, 2026
Implements [exploration 0444](docs/explorations/0444_[_]_EVICTION_AS_A_PRODUCT_FEATURE_BLOG.md) — 14/14 implementation items, 11/11 validation items. ## What this is Blog essay #23, on a single mechanism rather than a grievance: the platforms we keep our work in **have to be able to read it** (Notion says so plainly — end-to-end encryption would break search, sharing, integrations and AI), and the act that judges what they read is **welded to the act that takes it away**. Those two are separable. Nothing but the account-as-only-handle welds them. Grounded in eleven documented incidents across nine companies, sorted into five eviction triggers: content, category, jurisdiction, integration, and dormancy. ## Source discipline Every claim traces to a URL in the essay's `Sources` block (9 items, 33 links). Of those, 27 return 200, 5 are bot-blocks (403/000), and **none 404** — no fabricated citations. Three things were deliberately handled rather than glossed: - **The seed case is conceded in the essay's own voice.** The r/Notion user was running an airline-miles marketplace; Notion had grounds. The essay says so before a reader can, because the argument survives it — Notion still had to read the workspace to judge it, and still kept everything else. - **Two popular tellings are corrected in print.** Dropbox does *not* scan private folders (it hash-checks at share time), and no evidence emerged that Adobe trained on customer content. - **Nothing is quoted from the Reddit thread.** Reddit blocks automated readers on all three routes tried, so the post is described at second hand via LowEndBox and hamy.xyz, and the Sources block says exactly that. The Feb 2026 Google/OpenClaw case was flagged in the exploration as single-sourced and cut-if-uncorroborated. It corroborated across five outlets with a direct Google quote, so it stayed. ## The promise, made durable The essay commits xNet Cloud publicly to **refusal without confiscation** — we may decline to serve you, and that no can never take your work. Because a promise that only lives in a blog post scrolls away, it also lands in three places that outlive it: - `docs/CHARTER.md` §2 gains a "Refusal is not confiscation" paragraph - `site/src/data/commitments.ts` Exit mirrors it (the two are kept in sync by convention) - **ADR-36** records the decision with a `Tripwire:` — *the moment any hub role gains an action that removes a user's data rather than restricting its reach, this decision is void* It is checkable in code today: `PolicyBlockAction` is `reject | hide | quarantine | block-peer` and `AppealResolutionAction` is `reverse | annotate`. Every verb names reach; none names possession. Re-verified at publication time. ## Verification - `pnpm --filter site build` green; post renders at `/blog/the-door-inside-the-house`, appears on the index and in `rss.xml`, hero art renders on both - `pnpm typecheck` green; `pnpm lint` 0 errors (481 pre-existing warnings in untouched packages) - `check:humane-patterns`, `check:syndication`, `check:agent-docs`, `check:exploration-links` all green - Read at 320px — no overflow inside `<article>`; the 28px page overflow is pre-existing site chrome, identical on the already-published `the-table-and-the-wall` - `/humanize`: mirrored pairs brought from 2.35 → 0.39 /1k (threshold ≤0.5); em-dashes 0.00, reading ease 66.4, no bulleted lists in prose. `commonest opener` sits at 22.3%, the corpus norm the skill says to leave alone — it is the five-doors spine. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added the essay “The Door Inside the House,” exploring platform access, account suspensions, data custody, and export rights. * Added themed artwork, hero presentation, article navigation, and changelog coverage for the new post. * **Documentation** * Added ADR-36 clarifying that hosts may restrict service or content reach but cannot delete, revoke, or confiscate customer work. * Documented appeal mechanisms and customer-controlled, portable data protections. * Updated the Exit commitment to reflect these protections. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm --filter @xnetjs/editor typecheckpnpm --filter @xnetjs/editor exec vitest run src/extensions/live-preview/inline-marks.integration.test.tsPLAYWRIGHT_TEST_BASE_URL=http://127.0.0.1:5173 pnpm --filter @xnetjs/e2e-tests exec playwright test src/editor-markdown.spec.ts --project=chromium -g "inline mark|Backspace and Delete unwrap"pnpm typecheck && pnpm testpassed with 388 test files and 5553 passing tests.Merge Plan
Squash merge into
main.Summary by CodeRabbit
Release Notes
New Features
Improvements
Documentation