Move training-only dependencies to [train] extra #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
train-extra
branch
2 times, most recently
from
9c07d01 to
046d834
Compare
|
@crowsonkb Rebased on top of 0.1.0. |
|
@crowsonkb Rebased on top of 0.1.1. |
|
@crowsonkb Rebased on top of 0.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the dependencies required only for training to a
[train]package extra, to make it lighter for downstream consumers of the package (in line with the readme's statement "only library code that others can depend on").Due to how the project's
__init__.pyimports every submodule, I had to move the respective imports to be quite late.