Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multilingual option #725

Merged
merged 4 commits into from
Feb 22, 2024
Merged

feat: multilingual option #725

merged 4 commits into from
Feb 22, 2024

Conversation

katerina20
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (04a76c8) 63.73% compared to head (7661d83) 63.84%.
Report is 1 commits behind head on main.

Files Patch % Lines
...main/java/com/crowdin/cli/properties/FileBean.java 30.00% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #725      +/-   ##
============================================
+ Coverage     63.73%   63.84%   +0.12%     
- Complexity     1489     1493       +4     
============================================
  Files           220      220              
  Lines          6208     6216       +8     
  Branches        929      934       +5     
============================================
+ Hits           3956     3968      +12     
+ Misses         1751     1748       -3     
+ Partials        501      500       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -24,6 +24,7 @@ params.source=Path to the source files
params.translation=Path to the translation files
params.dest=Specify file name in Crowdin
params.preserve-hierarchy=Choose whether to save the directory hierarchy in the Crowdin project
params.multilingual=Specify whether file format is multilingual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
params.multilingual=Specify whether file format is multilingual

@@ -168,24 +168,20 @@ Example of the configuration:
]
```

#### Apple Strings Catalog
### Multilingual Support
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Multilingual Support
### Multilingual Files


Apple Strings Catalog is a natively supported file format by Crowdin, you can use it without any additional installation. Since this file format is **multilingual** (contains multiple languages in one file), you can omit the language placeholders in the `translation` pattern:
For multilingual file formats (contains multiple languages in one file), you can use the `multilingual` option in the configuration. With this option you can omit the language placeholders in the `translation` pattern:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For multilingual file formats (contains multiple languages in one file), you can use the `multilingual` option in the configuration. With this option you can omit the language placeholders in the `translation` pattern:
For multilingual file formats (containing multiple languages in one file) you can use the `multilingual` option in the configuration. This option allows you to omit the language placeholders in the `translation` pattern:

@andrii-bodnar andrii-bodnar merged commit 31e2053 into main Feb 22, 2024
8 checks passed
@andrii-bodnar andrii-bodnar deleted the feat/multilingual branch February 22, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants