feat: make error module public #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, yes this might be helpful indeed and this should be public. |
|
Let's merge this! Thanks for the change. |
|
Crossterm 5.5 fixes this. In case you where using GitHub link as dependencies move it over to crossterm 5.5, the coming days I'll have API breaking changes for 6.0 on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent introduction of the explicit error handling #69,
ResultandErrorKindtypes were added as part of the signature of some functions of the public api. In order to use this crate within an other one (e.g tui in my case), the error might need to be converted which is to my understanding impossible in the current state since those types are private. Thus this change makes the error module public.