Unwrap crossterm::Result<T, ErrorKind>
to std::io::Result
.
#765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing superficially wrapped Error types increases in most cases error handling complexity, both internally and externally.
https://github.com/fdehau/tui-rs/blob/fafad6c96109610825aad89c4bba5253e01101ed/src/backend/crossterm.rs#L125-L127
Generally, it becomes a nuisance every time one is working inside a function that returns a
Result<T, io::Error>
. Any expression that returns acrossterm::Result
leads to a mismatched type compile time error, even if the errors are practically the same.Unwrapping the type should also increase the transparency of the error origin.