Add execute_winapi on SetStyle to fix Windows compilation #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groves
force-pushed
the
SetStyle_windows_compilation
branch
from
fafe437
to
e4d16b1
Compare
|
#688 broke Windows compilation, too. I've added a fix for it to this branch. |
Merged
|
Oh thanks for patching! Must have slipped through in a previous PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation on Windows is failing for me currently with this error:
I believe #687 introduced the problem.
Reading
execute_fmt, I believe it'll callis_ansi_code_supportedon each of the subcommands, so this fix should be good.