Add CSIu parser for unix #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaggacao
force-pushed
the
add-csi-u-parser
branch
3 times, most recently
from
0d34b04
to
236d94b
Compare
blaggacao
force-pushed
the
add-csi-u-parser
branch
from
236d94b
to
7288f83
Compare
blaggacao
commented
Aug 23, 2021
Comment on lines
+269
to
+273
| // Issue #371: \n = 0xA, which is also the keycode for Ctrl+J. The only reason we get | ||
| // newlines as input is because the terminal converts \r into \n for us. When we | ||
| // enter raw mode, we disable that, so \n no longer has any meaning - it's better to | ||
| // use Ctrl+J. Waiting to handle it here means it gets picked up later | ||
| '\n' if !crate::terminal::sys::is_raw_mode_enabled() => KeyCode::Enter.into(), |
There was a problem hiding this comment.
I do not fully understand if the raw-mode check is warranted:
CSIu decimal ASCII encoding should be rather unambigous
10 -> LF
13 -> CR
There was a problem hiding this comment.
This pr have the context: #373
There was a problem hiding this comment.
Since the new line and CTRL+J overlapped in byte code, we need to pick one of them. Since newline doesn't occur when raw mode is enabled we can exclude \n in that case.
TimonPost
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #595
This is used for
helix-editorkeymaps.