GCW-3506 Update to react scripts 4 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
https://jira.crossroads.org.hk/browse/GCW-3506
What does this PR do?
Updates React Scripts to v4. Besides, new features, it also fixes an issue where creating a Tuple type would result in the following error
Line 0: Parsing error: Cannot read property 'map' of undefinedindirectly mentioned here facebook/create-react-app#9515The react-scripts update also upgrades the jest version to v26 and overrides the default value of
resetMocksfromfalsetotrue. This causes a lot of tests to fail, so to keep the previous behaviour, we override this setting in package.json.This particular change is mentioned here
facebook/create-react-app#7899
It is also mentioned in the jest repository at jestjs/jest#9047
And on Twitter: https://twitter.com/kentcdodds/status/1182744387190607872
Seems like a controversial decision as we also have people wanting the change reverted over here:
facebook/create-react-app#9935