Integrate `react-native-voice` into `expo-stt` #2

daheeahn · 2024-06-11T08:38:12Z

Currently, anhtuank7c/expo-stt has a separate Google voice recognition modal. Instead, I migrated the react-native-voice code onto this repository to use the built-in microphone like react-native-voice.
You can check the whole flow of voice recognition with README

github-actions · 2024-06-11T08:45:55Z

Risk Level 2 - /home/runner/work/expo-stt/expo-stt/example/App.tsx

The setRecognizing(false) call is removed from the onSpeechError listener. This could lead to the recognizing state being stuck as true in case of an error.

const onSpeechError = ExpoStt.addOnSpeechErrorListener(({ cause }) => {
    setError(cause);
    setRecognizing(false);
});

The disabled prop is removed from the "Stop speech" button. This could lead to the button being enabled even when speech recognition is not active.

<Button
    disabled={!recognizing}
    preset=\"warning\"
    title=\"Stop speech\"
    onPress={() => ExpoStt.stopSpeech()}
/>

Risk Level 3 - /home/runner/work/expo-stt/expo-stt/src/index.ts

The addOnSpeechResultListener function has been modified to include additional logic for handling results. Ensure that the listener is called with the correct event payload.

export function addOnSpeechResultListener(
    listener: (event: OnSpeechResultEventPayload) => void
): Subscription {
    return emitter.addListener<
        OnSpeechResultEventPayload & { results: string[] }
    >(\"onSpeechResult\", (event) => {
        const results = event.results;

        if (results && Array.isArray(results)) {
            const joinedResults = results.join(\" \");
            console.log(joinedResults);
            listener(event);

            return;
        }
    });
}

Ensure that the listener is called even if results is not an array to avoid missing events.

if (results && Array.isArray(results)) {
    const joinedResults = results.join(\" \");
    console.log(joinedResults);
}
listener(event);

Risk Level 4 - /home/runner/work/expo-stt/expo-stt/android/src/main/java/expo/modules/stt/ExpoSttModule.kt

The isRecognizing flag is not consistently updated in the onBeginningOfSpeech, onEndOfSpeech, and onError methods. This could lead to incorrect state management.

override fun onBeginningOfSpeech() {
    isRecognizing = true
    Log.d(TAG, \"onBeginningOfSpeech\")
}

override fun onEndOfSpeech() {
    isRecognizing = false
    Log.d(TAG, \"onEndOfSpeech\")
}

override fun onError(error: Int) {
    isRecognizing = false
    val errorMessage = when (error) {
        // error handling
    }
    sendEvent(onSpeechError, mapOf(\"errorMessage\" to errorMessage))
    Log.d(TAG, \"onError: $error $errorMessage\")
}

The sendEvent function calls are missing in onBeginningOfSpeech and onEndOfSpeech. This could lead to missing events.

override fun onBeginningOfSpeech() {
    isRecognizing = true
    sendEvent(onSpeechStart)
    Log.d(TAG, \"onBeginningOfSpeech\")
}

override fun onEndOfSpeech() {
    isRecognizing = false
    sendEvent(onSpeechEnd)
    Log.d(TAG, \"onEndOfSpeech\")
}

The requestRecognitionPermission function returns a map but does not use it. This could lead to confusion or missed information.

private fun requestRecognitionPermission(): Map<String, Any> {
    val currentActivity = appContext.currentActivity ?: throw CodedException(\"Activity is null\")
    val permission = Manifest.permission.RECORD_AUDIO
    val isGranted = ContextCompat.checkSelfPermission(currentActivity, permission) == PackageManager.PERMISSION_GRANTED

    if (!isGranted) {
        ActivityCompat.requestPermissions(currentActivity, arrayOf(permission), 1)
    }

    return mapOf(
        \"status\" to if (isGranted) \"granted\" else \"denied\",
        \"expires\" to \"never\",
        \"granted\" to isGranted,
        \"canAskAgain\" to true
    )
}

The onPartialResults method has commented-out logging. If logging is not needed, remove the commented code to keep the codebase clean.

🛠️ Code Quality Issues: Several instances where state management and event handling are inconsistent or missing, leading to potential bugs and incorrect behavior.

🚫 Removed Functionality: Critical functionality such as state updates and button disabling have been removed, which could lead to a poor user experience.

🔍 Attention to Detail: Minor issues like commented-out code and unused return values that need to be addressed to maintain a clean and efficient codebase.

Powered by Code Review GPT

daheeahn · 2024-06-11T08:48:37Z

I'll reflect review of GPT soon!!

- Commented out log statements (Kept log statements for future testing, commented out for now) - removed semicolons (there is no semicolons in kotlin)

daheeahn · 2024-06-13T06:32:00Z

Made minimal changes to maintain code consistency; no critical issues found

Done by expo-asset

hyochan · 2024-06-13T08:47:45Z

Fixed below android build error on my side in d51e53e

e: file:///Users/hyo/Github/crossplatformkorea/expo-stt/android/src/main/java/expo/modules/stt/ExpoSttModule.kt:56:17 Type mismatch: inferred type is Boolean? but Boolean was expected
e: file:///Users/hyo/Github/crossplatformkorea/expo-stt/android/src/main/java/expo/modules/stt/ExpoSttModule.kt:86:13 Expected a value of type Any?
e: file:///Users/hyo/Github/crossplatformkorea/expo-stt/android/src/main/java/expo/modules/stt/ExpoSttModule.kt:94:13 Expected a value of type Any?

hyochan

Nothing seems to happen when I press the Recognize speech button. Here are the logs I received:

 LOG  request permission null
 LOG  request permission null
 LOG  Check permission {"canAskAgain": true, "expires": "never", "granted": true, "status": "granted"}

Could you kindly share a screenshot of a working example? It would help me understand what the correct version should look like. Thank you!

hyochan

android.mp4

I am currently experiencing crashes on android device. Could you kindly check this?
If this is a permission issue, I think it'd be great to handle that in example either.

hyochan · 2024-07-04T06:59:29Z

Here is the logcat

2024-07-04 15:58:45.055 21312-21624 libc++abi               expo.modules.stt.example             E  terminating due to uncaught exception of type facebook::jsi::JSError: Cannot read property 'join' of undefined
                                                                                                    
                                                                                                    TypeError: Cannot read property 'join' of undefined
                                                                                                        at anonymous (http://localhost:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=expo.modules.stt.example&modulesOnly=false&runModule=true&transform.routerRoot=app&transform.engine=hermes&transform.bytecode=true:1344:33)
2024-07-04 15:58:45.056 21312-21624 libc                    expo.modules.stt.example             A  Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 21624 (mqt_js), pid 21312 (les.stt.example)
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A  Cmdline: expo.modules.stt.example
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A  pid: 21312, tid: 21624, name: mqt_js  >>> expo.modules.stt.example <<<
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A  Abort message: 'terminating due to uncaught exception of type facebook::jsi::JSError: Cannot read property 'join' of undefined
                                                                                                    
                                                                                                    TypeError: Cannot read property 'join' of undefined
                                                                                                        at anonymous (http://localhost:8081/index.bundle//&platform=android&dev=true&lazy=true&minify=false&app=expo.modules.stt.example&modulesOnly=false&runModule=true&transform.routerRoot=app&transform.engine=hermes&transform.bytecode=true:1344:33)'
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A        #01 pc 000000000009dd84  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libc++_shared.so (BuildId: 982d68842b3bd6a164609be09a533324b1f28526)
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A        #02 pc 000000000009ca44  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libc++_shared.so (BuildId: 982d68842b3bd6a164609be09a533324b1f28526)
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A        #03 pc 000000000009ced4  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libc++_shared.so (BuildId: 982d68842b3bd6a164609be09a533324b1f28526)
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A        #04 pc 000000000009ce74  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libc++_shared.so (std::terminate()+56) (BuildId: 982d68842b3bd6a164609be09a533324b1f28526)
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A        #05 pc 00000000000ae3b8  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libexpo-modules-core.so (BuildId: 6ea46ab51ef214194a6936eeb060545af9c82efc)
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A        #06 pc 00000000000aeaa8  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libexpo-modules-core.so (expo::EventEmitter::Listeners::call(facebook::jsi::Runtime&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> >, facebook::jsi::Object const&, facebook::jsi::Value const*, unsigned long)+744) (BuildId: 6ea46ab51ef214194a6936eeb060545af9c82efc)
2024-07-04 15:58:45.910 21803-21803 DEBUG                   pid-21803                            A        #07 pc 00000000000b0128  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libexpo-modules-core.so (expo::EventEmitter::emitEvent(facebook::jsi::Runtime&, facebook::jsi::Object const&, std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&, facebook::jsi::Value const*, unsigned long)+216) (BuildId: 6ea46ab51ef214194a6936eeb060545af9c82efc)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #08 pc 00000000000ea874  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libexpo-modules-core.so (BuildId: 6ea46ab51ef214194a6936eeb060545af9c82efc)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #09 pc 00000000001f5d40  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #10 pc 00000000001f5c28  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (std::__ndk1::function<void ()>::operator()() const+20) (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #11 pc 000000000027d734  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #12 pc 000000000027d70c  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #13 pc 000000000027d6bc  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #14 pc 000000000027d690  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #15 pc 000000000027c724  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #16 pc 0000000000284abc  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #17 pc 00000000002830b0  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (std::__ndk1::function<void (facebook::jsi::Runtime&)>::operator()(facebook::jsi::Runtime&) const+28) (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #18 pc 0000000000287428  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #19 pc 00000000002873bc  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #20 pc 000000000028736c  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #21 pc 0000000000287340  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #22 pc 00000000002862c4  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #23 pc 0000000000284abc  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #24 pc 00000000002830b0  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (std::__ndk1::function<void (facebook::jsi::Runtime&)>::operator()(facebook::jsi::Runtime&) const+28) (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #25 pc 00000000002b2944  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #26 pc 00000000002b28bc  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #27 pc 00000000002b2868  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #28 pc 00000000002b283c  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #29 pc 00000000002b18b4  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #30 pc 00000000002d94dc  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #31 pc 00000000002d9440  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (std::__ndk1::function<void (facebook::react::JSExecutor*)>::operator()(facebook::react::JSExecutor*) const+44) (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #32 pc 00000000002d9400  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #33 pc 00000000002d9398  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #34 pc 00000000002d9350  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #35 pc 00000000002d932c  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #36 pc 00000000002d821c  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #37 pc 00000000001f5d40  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #38 pc 00000000001f5c28  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (std::__ndk1::function<void ()>::operator()() const+20) (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #39 pc 0000000000210934  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #40 pc 00000000002108cc  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #41 pc 0000000000210884  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #42 pc 0000000000210860  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #43 pc 000000000020f818  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libreactnativejni.so (BuildId: c47ef889b966436f)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #44 pc 0000000000019804  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libfbjni.so (facebook::jni::detail::MethodWrapper<void (facebook::jni::JNativeRunnable::*)(), &(facebook::jni::JNativeRunnable::run()), facebook::jni::JNativeRunnable, void>::dispatch(facebook::jni::alias_ref<facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::jni::JNativeRunnable, facebook::jni::JRunnable>::JavaPart, facebook::jni::JRunnable, void>::_javaobject*>)+72) (BuildId: a22242831a7971267de570e06121acb588ce64cd)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #45 pc 0000000000019744  /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk!libfbjni.so (facebook::jni::detail::FunctionWrapper<void (*)(facebook::jni::alias_ref<facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::jni::JNativeRunnable, facebook::jni::JRunnable>::JavaPart, facebook::jni::JRunnable, void>::_javaobject*>), facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::jni::JNativeRunnable, facebook::jni::JRunnable>::JavaPart, facebook::jni::JRunnable, void>::_javaobject*, void>::call(_JNIEnv*, _jobject*, void (*)(facebook::jni::alias_ref<facebook::jni::detail::JTypeFor<facebook::jni::HybridClass<facebook::jni::JNativeRunnable, facebook::jni::JRunnable>::JavaPart, facebook::jni::JRunnable, void>::_javaobject*>))+60) (BuildId: a22242831a7971267de570e06121acb588ce64cd)
2024-07-04 15:58:45.911 21803-21803 DEBUG                   pid-21803                            A        #50 pc 00000000002cb36c  [anon:dalvik-classes.dex extracted in memory from /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk] (com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage+0)
2024-07-04 15:58:45.912 21803-21803 DEBUG                   pid-21803                            A        #59 pc 00000000002cb4fa  [anon:dalvik-classes.dex extracted in memory from /data/app/~~xyYMsU5MEi2bQe0GRqBIfQ==/expo.modules.stt.example-XAGLXqF1G4B-aLeo8Pe5dQ==/base.apk] (com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run+74)

Related https://github.com/crossplatformkorea/expo-stt/pull/2\#issuecomment-2208255268

hyochan added the enhancement New feature or request label Jun 11, 2024

daheeahn added 9 commits June 11, 2024 17:43

feat: migrate voice functionality from react-native-voice to expo-stt

46653a0

update README

0806681

update README

afc05b5

remove package-lock.json

077e058

chore: run npx expo prebuild

feba7d8

update gitignore

b557394

update yarn.lock

5b9b86d

run bun install

ce06229

remove build folder

faac065

daheeahn force-pushed the feature/react-native-voice-integration branch from d55d27a to faac065 Compare June 11, 2024 08:44

fix Code Consistency

f10d58e

- Commented out log statements (Kept log statements for future testing, commented out for now) - removed semicolons (there is no semicolons in kotlin)

hyochan added 2 commits June 13, 2024 17:45

chore: optimize assets

3c6a750

Done by expo-asset

fix: android build issue

d51e53e

hyochan requested changes Jun 13, 2024

View reviewed changes

daheeahn and others added 10 commits June 18, 2024 00:17

fix: add permission setting

a3eb96c

fix: un-comment log statements for test

8896c9d

chore(deps): update packages

c7c5ad0

chore: expo prebuild

ccbcd68

chore: bun install && prebuild

5fd6881

feat: add permission message

02ae1b4

feat: add permission message

df10724

chore: prebuild ios

796a341

feat: add auto finish of speech recognition to ios

a0efcf6

chore: expo assets

7e2bdb9

hyochan requested changes Jul 4, 2024

View reviewed changes

fix: crashing on start speech

d08362c

Related https://github.com/crossplatformkorea/expo-stt/pull/2\#issuecomment-2208255268

hyochan approved these changes Jul 22, 2024

View reviewed changes

hyochan merged commit bd8fa61 into main Jul 22, 2024
2 checks passed

hyochan deleted the feature/react-native-voice-integration branch July 22, 2024 17:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate `react-native-voice` into `expo-stt` #2

Integrate `react-native-voice` into `expo-stt` #2

daheeahn commented Jun 11, 2024

github-actions bot commented Jun 11, 2024 •

edited

Loading

daheeahn commented Jun 11, 2024

daheeahn commented Jun 13, 2024

hyochan commented Jun 13, 2024

hyochan left a comment

hyochan left a comment

hyochan commented Jul 4, 2024

Integrate react-native-voice into expo-stt #2

Integrate react-native-voice into expo-stt #2

Conversation

daheeahn commented Jun 11, 2024

github-actions bot commented Jun 11, 2024 • edited Loading

Powered by Code Review GPT

daheeahn commented Jun 11, 2024

daheeahn commented Jun 13, 2024

hyochan commented Jun 13, 2024

hyochan left a comment

Choose a reason for hiding this comment

hyochan left a comment

Choose a reason for hiding this comment

hyochan commented Jul 4, 2024

Integrate `react-native-voice` into `expo-stt` #2

Integrate `react-native-voice` into `expo-stt` #2

github-actions bot commented Jun 11, 2024 •

edited

Loading