Add support for Orphan management policy #864
Open
+267
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6694 Signed-off-by: Bob Haddleton <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
build: remove release-1.18 from Renovate baseBranches
Signed-off-by: Mangirdas Judeikis <[email protected]>
Fix npe in reconciler
Fixes #6694 Signed-off-by: Bob Haddleton <[email protected]>
Signed-off-by: Bob Haddleton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Added an Orphan management policy value which maps to ['Observe', 'Create', 'Update', 'LateInitialize'] in order to simplify the migration from
deletionPolicytomanagementPoliciesand facilitate controlled orphaning of resources.Fixes #6694 (Crossplane)
Tested using provider-kubernetes running a private branch of crossplane-runtime. Created an
Objectcontaining aSecretwith themanagementPolicies: ['Orphan']and verified that when theObjectwas deleted theSecretremained.Docs PR is crossplane/docs#993
I have:
earthly +reviewableto ensure this PR is ready for review.- [ ] Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.