Use GitHub releases, not tags, for Earthfile deps #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notably CodeQL seems to have a tag cut that doesn't exist as a release. Signed-off-by: Nic Cope <[email protected]>
jbw976
approved these changes
May 30, 2024
| @@ -40,7 +40,7 @@ | |||
| "matchStrings": [ | |||
| "EARTHLY_VERSION: '(?<currentValue>.*?)'\\n" | |||
| ], | |||
| "datasourceTemplate": "github-tags", | |||
There was a problem hiding this comment.
this is intended for other managers besides just codeql?
There was a problem hiding this comment.
Yeah, I figured since we always download release artifact URLs it's better to use the existence of a release as the datasource everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Notably CodeQL seems to have a tag cut that doesn't exist as a release.
I have:
earthly +reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.